Conversation
Codecov ReportAttention: Patch coverage is
|
lkdvos
reviewed
Feb 3, 2025
Member
lkdvos
left a comment
lkdvos
left a comment
There was a problem hiding this comment.
Overall, looks clean to me. Can you confirm that the PEPSKit changes you want have passing tests before I merge and tag any of this?
Co-authored-by: Lukas Devos <ldevos98@gmail.com>
leburgel
changed the title
lkdvos
approved these changes
Feb 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempt at relaxing the type restrictions on MPO elements, in order to be able to use generic effective MPOs. This should work as long as the element type adheres to the (until now implicit) interface for
MPOTensorwhich requires:left_virtualspaceright_virtualspace_conj_mpoadd_physical_charge_fuse_mpo_mpo_fuse_mpo_mps_mpo_to_mpsI also added explicit type annotations for internal methods where an element type
<:MPOTensoris really assumed.See also QuantumKitHub/PEPSKit.jl#125 for the intended use case.