Refactor boundary MPS contractions to directly use MPSKit.InfiniteMPO#125
Merged
Refactor boundary MPS contractions to directly use MPSKit.InfiniteMPO#125
MPSKit.InfiniteMPO#125Conversation
Codecov ReportAttention: Patch coverage is
|
leburgel
changed the title
MPSKit.InfiniteMPOMPSKit.InfiniteMPO
lkdvos
approved these changes
Feb 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactors the support for boundary MPS contractions after QuantumKitHub/MPSKit.jl#244. This moves away from using custom structs for transfer matrices corresponding to PEPS and PEPO sandwiches, and instead implements these as
MPSKit.InfiniteMPOinstances. All we now require is some custom constructors to map the appropriate collections of networks to the corresponding MPOs, and implement the expected interface (here, just the actual contraction methods and virtual space utilities) for the different element types.Given how this turned out, I think we should move to a similar approach for representing all 2D contractible networks which just wraps a matrix of effective local MPO tensors, just like
InfiniteMPOnow just wraps a vector of generic effective MPO tensors. See also #116.