-
Notifications
You must be signed in to change notification settings - Fork 5
Test truncated methods with GPU arrays #142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would slightly prefer to have these changes as specializations in the GPU extensions, but definitely happy to try them out like this
|
OK, got the column permutation for |
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
|
We can probably use the struct Truncerr_BinaryAdder{T}
p::T
end
(a::Truncerr_BinaryAdder)(x, y) = x + abs(y)^a.pThen in the GPU extensions do: But that can happen in a separate PR since this is holding up TK. |
Co-authored-by: Lukas Devos <[email protected]>
Co-authored-by: Lukas Devos <[email protected]>
Co-authored-by: Lukas Devos <[email protected]>
* Bump version * update changelog --------- Co-authored-by: Lukas Devos <[email protected]>
Try to address #138