tests: Specific Group Presentations Using Oscar's Free Group for Non-Abelian and Abelian Groups#390
tests: Specific Group Presentations Using Oscar's Free Group for Non-Abelian and Abelian Groups#390Fe-r-oz wants to merge 4 commits intoQuantumSavory:masterfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #390 +/- ##
==========================================
- Coverage 83.06% 82.76% -0.31%
==========================================
Files 70 70
Lines 4410 4426 +16
==========================================
Hits 3663 3663
- Misses 747 763 +16 ☔ View full report in Codecov by Sentry. |
|
@Krastanov, @royess, There are many groups mentioned in the aforementioned paper which are used to create group algebra using direct products/semi products of following groups which are not currently supported which is the aim of this PR:
where There are two methods for using these non-abelian groups based on discussion with Oscar Team. Using This approach does not need This PR aims to handle all the code instances from Appendix Table 3 of aforementioned paper where authors take direct product of Dihedral and cyclic groups ( The users enter the
The other approach is to use semi direct products which is #382 which provides a more hands on approach where we can construct the group structure itself mainly when semidirect products are required. This is useful when custom group presentations with relators ( I will turn this to draft to incorporate any more feedback and comments. |
|
The above comment #390 (comment) only deals with construction Table 1 only uses a slight different approach. Given one I have added a function for this as well. |
|
The PR is nearly implemented. But turning this to WIP as I will add and test the entire non-abelian Table 3 and Table 1 results as well with Hecke.small_group by adding them as test cases. |
|
Since #391 has been resolved, The Table 1 results has been reproduced! I have verified the Table 1 results and will push it the test file once the bug in Issue 394 is resolved.
In this case, a key piece of information, presentation column, is necessary to construct such abelian and non-abelian groups. Simply using As pointed out by Tommy, this will be done via |
ee75c4f to
ae51ea2
Compare
|
Can this be updated to have the appropriate tags given how we reorganized the tests recently? |

This PR aims to add new method for the two-block group codes using non-abelian groups. Reference Table 1: https://arxiv.org/pdf/2306.16400.