tests: Group Presentation for Cyclic Group Cₘₕ = Cₘ × C₂#398
Draft
Fe-r-oz wants to merge 8 commits intoQuantumSavory:masterfrom
Draft
tests: Group Presentation for Cyclic Group Cₘₕ = Cₘ × C₂#398Fe-r-oz wants to merge 8 commits intoQuantumSavory:masterfrom
Fe-r-oz wants to merge 8 commits intoQuantumSavory:masterfrom
Conversation
Fe-r-oz
force-pushed
the
cyclicpresentation
branch
from
d3162ae to
d47f59f
Compare
Fe-r-oz
changed the title
Fe-r-oz
force-pushed
the
cyclicpresentation
branch
from
d47f59f to
275db7a
Compare
Contributor
Author
|
The [[N,K,D]] values of all the table 2 codes formed via group presentation has been tested! These tests are related to #400 and they run on |
Fe-r-oz
added
the
Skip-Changelog
Contributor
Author
|
@Krastanov, just a friendly bump on this PR when you have a moment! |
Krastanov
reviewed
Dec 31, 2025
| @@ -0,0 +1,210 @@ | |||
| @testitem "ECC 2BGA Table 2 via Presentation of Cyclic Groups" tags=[:ecc] begin | |||
| @static if !Sys.iswindows() && Sys.ARCH == :x86_64 && VERSION >= v"1.11" | |||
Member
There was a problem hiding this comment.
we now have a particular tag that filters tests that require oscar centrally
Krastanov
reviewed
Dec 31, 2025
| using Nemo: FqFieldElem | ||
| using Hecke: group_algebra, GF, abelian_group, gens, quo, one, GroupAlgebra | ||
| using QuantumClifford.ECC | ||
| using QuantumClifford.ECC: code_k, code_n, two_block_group_algebra_codes, twobga_from_fp_group |
Member
There was a problem hiding this comment.
two_block_group_algebra_codes is now renamed to singular
Krastanov
reviewed
Dec 31, 2025
| @@ -0,0 +1,210 @@ | |||
| @testitem "ECC 2BGA Table 2 via Presentation of Cyclic Groups" tags=[:ecc] begin | |||
Member
There was a problem hiding this comment.
and we have more fine-grained tags now, so that these run on separate test runners
Member
|
converting to draft, but feel free to convert to non-draft when ready for review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reproduces the Table 2 by using presentation of cyclic group instead of Direct Product of cyclic groups which was done in: #392
As$C_{mh} = C_m \times C_2 = \langle x, s \mid x^m = s^2 = xsx^{-1}s^{-1} = 1 \rangle$ , there are two ways to reproduce Table 2:
This PR implements the 2) approach. This second approach was not mentioned in the caption of Table 2 but was referenced in the text of the Appendix. Both gives the same results.