Fix: XSS vulnerability in format_cover_html#820
Open
Jah-yee wants to merge 3 commits intoQwenLM:mainfrom
Open
Conversation
Add threading lock to prevent race condition in singleton pattern. In multi-threaded environments (e.g., Gradio WebUI or ASGI servers), two threads could simultaneously evaluate _instance is None as True, creating duplicate MCP server connections and causing inconsistent state. This fix ensures atomic instance creation using a class-level lock.
Fixed typo in README.md line 173.
Escape user-supplied bot_name and bot_description using html.escape() to prevent potential XSS attacks when rendering the Gradio WebUI. Fixes: Issue QwenLM#810
Jah-yee
force-pushed
the
fix/xss-vulnerability-gradio-utils
branch
from
c426ca8 to
3571a1a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Escape user-supplied
bot_nameandbot_descriptionusinghtml.escape()to prevent arbitrary JavaScript injection via agent configuration.Changes
import htmlto gradio_utils.pyFixes
Fixes issue #810
Testing
The fix uses Python standard library
html.escape()which converts:<to<>to>&to&"to"This prevents any HTML/JS injection in the Gradio WebUI.