Skip to content

Fix: XSS vulnerability in format_cover_html #820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Jah-yee wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix: XSS vulnerability in format_cover_html #820

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6530507
fix: make MCPManager singleton thread-safe
Mar 10, 2026
e31a574
fix typo: implemetation -> implementation
Mar 10, 2026
3571a1a
Fix XSS vulnerability in format_cover_html
Mar 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@ while True:
messages.extend(response)
```

In addition to using built-in agent implementations such as `class Assistant`, you can also develop your own agent implemetation by inheriting from `class Agent`.
In addition to using built-in agent implementations such as `class Assistant`, you can also develop your own agent implementation by inheriting from `class Agent`.

The framework also provides a convenient GUI interface, supporting the rapid deployment of Gradio Demos for Agents.
For example, in the case above, you can quickly launch a Gradio Demo using the following code:
Expand Down
8 changes: 6 additions & 2 deletions qwen_agent/gui/gradio_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
# limitations under the License.

import base64
import html


def covert_image_to_base64(image_path):
Expand All @@ -36,6 +37,9 @@ def format_cover_html(bot_name, bot_description, bot_avatar):
image_src = covert_image_to_base64(bot_avatar)
else:
image_src = '//img.alicdn.com/imgextra/i3/O1CN01YPqZFO1YNZerQfSBk_!!6000000003047-0-tps-225-225.jpg'
# Escape user input to prevent XSS attacks
safe_bot_name = html.escape(bot_name)
safe_bot_description = html.escape(bot_description)
return f"""
<style>
body.dark-mode .bot_cover {{
Expand Down Expand Up @@ -74,7 +78,7 @@ def format_cover_html(bot_name, bot_description, bot_avatar):
<div class="bot_avatar">
<img src="{image_src}" />
</div>
<div class="bot_name">{bot_name}</div>
<div class="bot_desp">{bot_description}</div>
<div class="bot_name">{safe_bot_name}</div>
<div class="bot_desp">{safe_bot_description}</div>
</div>
"""
6 changes: 4 additions & 2 deletions qwen_agent/tools/mcp_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,12 @@

class MCPManager:
_instance = None # Private class variable to store the unique instance
_lock = threading.Lock() # Class-level lock for thread-safe singleton

def __new__(cls, *args, **kwargs):
if cls._instance is None:
cls._instance = super(MCPManager, cls).__new__(cls, *args, **kwargs)
with cls._lock:
if cls._instance is None:
cls._instance = super(MCPManager, cls).__new__(cls, *args, **kwargs)
return cls._instance

def __init__(self):
Expand Down