chore: remove CJS/UMD builds#8103
Merged
wmertens merged 4 commits intoQwikDev:build/v2from Nov 10, 2025
Merged
Conversation
🦋 Changeset detectedLatest commit: fe3fbb6 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Author
|
Create Pr for testing |
commit: |
Contributor
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
wmertens
reviewed
Oct 31, 2025
wmertens
changed the title
wmertens
reviewed
Nov 6, 2025
Member
There was a problem hiding this comment.
Very nice!
Can you also add a separate commit that puts "type": "module" in all those package.json files?
And add a changeset with a major change that says something like BREAKING: the CJS/UMD builds have been removed; ESM is well-supported everywhere and allows better optimizations.
JerryWu1234
force-pushed
the
no-cjs
branch
5 times, most recently
from
40671a0 to
38e8cee
Compare
gioboa
approved these changes
Nov 10, 2025
Contributor
Author
Done |
auto-merge was automatically disabled
November 10, 2025 08:23
Head branch was pushed to by a user without write access
…ating scripts and package configurations rename changeset
Contributor
|
good job @JerryWu1234 ! 🎉 🙏 |
JerryWu1234
added a commit
to JerryWu1234/qwik
that referenced
this pull request
Dec 9, 2025
After PR QwikDev#8103 migrated from CJS to ESM, the execa package was marked as external in the esbuild config but was not declared as a dependency in create-qwik's package.json. This caused 'Cannot find package execa' error when running: npx create-qwik@2.0.0-beta.15 Fixes the runtime error by adding execa to dependencies.
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…e. Remove CJS generation configuration one module at a time, which makes it easier to find bugs.
What is it?
Description
Checklist
pnpm change