Skip to content

Add pytest in automatic parking package #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
robotpilot merged 3 commits into from
Jun 20, 2025
Merged

Add pytest in automatic parking package #73

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
23d9b85
add pytest in automatic docking
GyuH13 Jun 20, 2025
eedf168
Merge branch 'main' of https://github.com/ROBOTIS-GIT/turtlebot3_appl…
GyuH13 Jun 20, 2025
991d918
bump
GyuH13 Jun 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions turtlebot3_applications/CHANGELOG.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,11 @@
Changelog for package turtlebot3_applications
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

1.3.2 (2025-06-20)
------------------
* Add pytest in setup.py
* Contributors: Hyungyu Kim

1.3.1 (2025-06-20)
------------------
* Fix cmake error in turtlebot3_panorama
Expand Down
2 changes: 1 addition & 1 deletion turtlebot3_applications/package.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<?xml-model href="http://download.ros.org/schema/package_format3.xsd" schematypens="http://www.w3.org/2001/XMLSchema"?>
<package format="3">
<name>turtlebot3_applications</name>
<version>1.3.1</version>
<version>1.3.2</version>
<description>
ROS packages for the turtlebot3 applications (meta package)
</description>
Expand Down
4 changes: 4 additions & 0 deletions turtlebot3_aruco_tracker/CHANGELOG.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@
Changelog for package turtlebot3_aruco_tracker
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

1.3.2 (2025-06-20)
------------------
* None

1.3.1 (2025-06-20)
------------------
* None
Expand Down
2 changes: 1 addition & 1 deletion turtlebot3_aruco_tracker/package.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<?xml-model href="http://download.ros.org/schema/package_format3.xsd" schematypens="http://www.w3.org/2001/XMLSchema"?>
<package format="3">
<name>turtlebot3_aruco_tracker</name>
<version>1.3.1</version>
<version>1.3.2</version>
<description>
ArUco Tracker for TurtleBot3 Examples.
</description>
Expand Down
2 changes: 1 addition & 1 deletion turtlebot3_aruco_tracker/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

setup(
name=package_name,
version='1.3.1',
version='1.3.2',
packages=find_packages(),
data_files=[
('share/ament_index/resource_index/packages', ['resource/' + package_name]),
Expand Down
5 changes: 5 additions & 0 deletions turtlebot3_automatic_parking/CHANGELOG.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,11 @@
Changelog for package turtlebot3_automatic_parking
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

1.3.2 (2025-06-20)
------------------
* Add pytest in setup.py
* Contributors: Hyungyu Kim

1.3.1 (2025-06-20)
------------------
* None
Expand Down
4 changes: 2 additions & 2 deletions turtlebot3_automatic_parking/package.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@
<?xml-model href="http://download.ros.org/schema/package_format3.xsd" schematypens="http://www.w3.org/2001/XMLSchema"?>
<package format="3">
<name>turtlebot3_automatic_parking</name>
<version>1.3.1</version>
<version>1.3.2</version>
<description>
Package for turtlebot3 automatic_parking. You need a reflective tape and real robots. You can see parking spot using this pacakge on rviz.
Package for turtlebot3 automatic_parking.
</description>
<maintainer email="pyo@robotis.com">Pyo</maintainer>
<license>Apache 2.0</license>
Expand Down
9 changes: 5 additions & 4 deletions turtlebot3_automatic_parking/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@

setup(
name=package_name,
version='1.3.1',
version='1.3.2',
packages=find_packages(),
data_files=[
('share/ament_index/resource_index/packages', ['resource/' + package_name]),
Expand All @@ -24,8 +24,8 @@
zip_safe=True,
author=['Gilbert'],
author_email=['kkjong@robotis.com'],
maintainer='Will Son',
maintainer_email='willson@robotis.com',
maintainer='Pyo',
maintainer_email='pyo@robotis.com',
keywords=['ROS', 'ROS2', 'examples', 'rclpy'],
classifiers=[
'Intended Audience :: Developers',
Expand All @@ -34,9 +34,10 @@
'Topic :: Software Development',
],
description=(
'Examples of Different TurtleBot3 Usage.'
'Package for turtlebot3 automatic_parking.'
),
license='Apache License, Version 2.0',
tests_require=['pytest'],
Copy link

Copilot AI Jun 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider using extras_require (e.g., extras_require={'test': ['pytest']}) instead of tests_require to align with current best practices for dependency management.

Suggested change
tests_require=['pytest'],
extras_require={
'test': ['pytest'],
},

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot Jun 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Adding pytest to tests_require here is a valid step for setuptools, enabling python setup.py test to find pytest.

However, for ROS 2 packages, it's crucial to also declare test dependencies in package.xml. This ensures that ROS 2 build and test tools, such as colcon, can correctly identify and manage these dependencies.

Please consider adding the following to your package.xml file:

<test_depend>pytest</test_depend>

Reasoning:
ROS 2 build systems (e.g., colcon) primarily rely on package.xml for dependency resolution. If pytest is not listed as a <test_depend>, colcon test might fail to set up the testing environment correctly (e.g., pytest might not be installed or visible in the workspace). This can hinder the standard testing workflow for ROS 2 packages and cause issues in CI or for other developers.

entry_points={
'console_scripts': [
'turtlebot3_automatic_parking = \
Expand Down
4 changes: 4 additions & 0 deletions turtlebot3_automatic_parking_vision/CHANGELOG.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@
Changelog for package turtlebot3_automatic_parking_vision
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

1.3.2 (2025-06-20)
------------------
* None

1.3.1 (2025-06-20)
------------------
* None
Expand Down
2 changes: 1 addition & 1 deletion turtlebot3_automatic_parking_vision/package.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<?xml-model href="http://download.ros.org/schema/package_format3.xsd" schematypens="http://www.w3.org/2001/XMLSchema"?>
<package format="3">
<name>turtlebot3_automatic_parking_vision</name>
<version>1.3.1</version>
<version>1.3.2</version>
<description>
Automatic Parking Vision for TurtleBot3 Examples.
</description>
Expand Down
2 changes: 1 addition & 1 deletion turtlebot3_automatic_parking_vision/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

setup(
name=package_name,
version='1.3.1',
version='1.3.2',
packages=find_packages(),
data_files=[
('share/ament_index/resource_index/packages', ['resource/' + package_name]),
Expand Down
4 changes: 4 additions & 0 deletions turtlebot3_follower/CHANGELOG.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@
Changelog for package turtlebot3_follower
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

1.3.2 (2025-06-20)
------------------
* None

1.3.1 (2025-06-20)
------------------
* None
Expand Down
2 changes: 1 addition & 1 deletion turtlebot3_follower/package.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<?xml-model href="http://download.ros.org/schema/package_format3.xsd" schematypens="http://www.w3.org/2001/XMLSchema"?>
<package format="3">
<name>turtlebot3_follower</name>
<version>1.3.1</version>
<version>1.3.2</version>
<description>
TurtleBot3 Follower Example for ROS2.
</description>
Expand Down
4 changes: 4 additions & 0 deletions turtlebot3_panorama/CHANGELOG.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@
Changelog for package turtlebot3_panorama
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

1.3.2 (2025-06-20)
------------------
* None

1.3.1 (2025-06-20)
------------------
* Fix cmake error in turtlebot3_panorama
Expand Down
1 change: 0 additions & 1 deletion turtlebot3_panorama/include/turtlebot3_panorama/panorama.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,6 @@
#include <cv_bridge/cv_bridge.hpp>
#endif


#include "turtlebot3_applications_msgs/srv/take_panorama.hpp"
#include "turtlebot3_panorama/geometry.hpp"

Expand Down
2 changes: 1 addition & 1 deletion turtlebot3_panorama/package.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<?xml-model href="http://download.ros.org/schema/package_format3.xsd" schematypens="http://www.w3.org/2001/XMLSchema"?>
<package format="3">
<name>turtlebot3_panorama</name>
<version>1.3.1</version>
<version>1.3.2</version>
<description>
Package for turtlebot3 panorama.
</description>
Expand Down
4 changes: 4 additions & 0 deletions turtlebot3_yolo_object_detection/CHANGELOG.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@
Changelog for package turtlebot3_yolo_object_detection
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

1.3.2 (2025-06-20)
------------------
* None

1.3.1 (2025-06-20)
------------------
* None
Expand Down
2 changes: 1 addition & 1 deletion turtlebot3_yolo_object_detection/package.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<?xml-model href="http://download.ros.org/schema/package_format3.xsd" schematypens="http://www.w3.org/2001/XMLSchema"?>
<package format="3">
<name>turtlebot3_yolo_object_detection</name>
<version>1.3.1</version>
<version>1.3.2</version>
<description>
YOLO-based object detection for TurtleBot3
</description>
Expand Down
2 changes: 1 addition & 1 deletion turtlebot3_yolo_object_detection/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

setup(
name=package_name,
version='1.3.1',
version='1.3.2',
packages=find_packages(),
data_files=[
('share/ament_index/resource_index/packages', ['resource/' + package_name]),
Expand Down
Loading