Fix GCC 15 build failure by connecting bundled yaml-cpp for rocprofiler-sdk

[Muhamed-Husic]

Motivation

Partially solves: #3517

As already established GCC 15 defaults to -std=gnu23 and no longer pulls in headers like <cstdint> transitively. The vendored yaml-cpp inside rocprofiler-sdk fails to build under GCC 15.

This PR implements the approach recommended by the mainteier.

Technical Details

Added THEROCK_BUNDLED_YAMLCPP to CMakeLists.txt following the same pattern as other bundeled sysdeps like sqlite3 and zstd.

In profiler/CMakeLists.txt connected it so that _rocprof_use_sys_yaml_cpp is derived from wheather THEROCK_BUNDLED_YAMLCPP is set, and passes ${THEROCK_BUNDLED_YAMLCPP} as a runtime dep to the rocprofiler-sdk component.

Submission Checklist

• Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.

Related

• Connected to PR that is in rocm-systems that adds the ROCPROF_USE_SYS_YAML_CPP here.

Notes

Issue pointed that rocm-systems/projects/rocprofiler-systems/source/lib/logger/logger.hpp produces error because there is no #include <algorithm> in that file, however there is (at least now). See here..

Also rocm-libraries/projects/hipdnn/plugins/miopen_legacy_plugin/MiopenContainer.hpp was mentioned in the description of the issue, however it was moved (I assume it is this file), but it doesn't make any problems.

[Muhamed-Husic]

While working on this issue, I have noticed syntax typo in root's CMakeLists.txt. I opened PR for it here.

[marbre]

While working on this issue, I have noticed syntax typo in root's CMakeLists.txt. I opened PR for it here.

Thanks, already approved and landed that.

[marbre]

Thanks, I think this would work. Let's wait until the patch this depends on went into rocm-systems. Please then ping for a re-review. Feel free to fix the double whitespaces in the meantime :) Your work is definitely appreciated.

[marbre]

Suggested change

	set(THEROCK_BUNDLED_YAMLCPP therock-yaml-cpp)
	set(THEROCK_BUNDLED_YAMLCPP therock-yaml-cpp)

Seems there is one whitespace too much.

[Muhamed-Husic]

Thank you for the quick feedback. I fixed the whitespace issues and will ping you for a re-review once the dependent patch is merged into rocm-systems.