Added ROCPROF_USE_SYS_YAML_CPP option to allow system-provided yaml-cpp#4223
Open
Muhamed-Husic wants to merge 2 commits intoROCm:developfrom
Open
Added ROCPROF_USE_SYS_YAML_CPP option to allow system-provided yaml-cpp#4223Muhamed-Husic wants to merge 2 commits intoROCm:developfrom
Muhamed-Husic wants to merge 2 commits intoROCm:developfrom
Conversation
1 task
Author
|
Note that this PR is connected to ROCm/TheRock#4066. |
marbre
reviewed
Mar 19, 2026
Member
marbre
left a comment
marbre
left a comment
There was a problem hiding this comment.
This fix should do it IMHO and would help to move away from the bundled dep. @jbonnell-amd I leave the review to you or otherwise please find someone to look at it.
Collaborator
Thanks, I took a quick look and it seems fine but I'll add in the SDK team for their input first (@venkat1361 @jrmadsen @sadikarmagan) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Partially solves:: #3517
TheRock already provides yaml-cpp as sysdep (similar to sqlite3, zstd, etc.). Without this option, rocprofiler-sdk always builds its own vendored copy, which conflicts with TheRock's dependency management and prevents it from supplying its own yaml-cpp.
This option gives TheRock the ability to opt out of the vendored copy and supply yaml-cpp externaly.
Technical Details
Added
ROCPROF_USE_SYS_YAML_CPPoption intoprojects/rocprofiler-sdk/external/CMakeLists.txt. When enabled the build finds system yaml-cpp instead of building the vendored copy.Submission Checklist
Related