Skip to content

Added ROCPROF_USE_SYS_YAML_CPP option to allow system-provided yaml-cpp #4223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Muhamed-Husic wants to merge 2 commits into
base: develop
Choose a base branch
from
+18 −5
Open

Added ROCPROF_USE_SYS_YAML_CPP option to allow system-provided yaml-cpp #4223

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a3dc49a
Add ROCPROF_USE_SYS_YAML_CPP flag for system yaml-cpp
Muhamed-Husic Mar 17, 2026
c84ab9e
Dead code removal
Muhamed-Husic Mar 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 18 additions & 5 deletions projects/rocprofiler-sdk/external/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,13 +138,26 @@ rocprofiler_checkout_git_submodule(
REPO_URL https://github.com/jbeder/yaml-cpp.git
REPO_BRANCH "master")

add_subdirectory(yaml-cpp EXCLUDE_FROM_ALL)

# Prefer system-provided yaml-cpp over vendored one
option(ROCPROF_USE_SYS_YAML_CPP
"Use system-provided yaml-cpp instead of vendored external/yaml-cpp" ON)

if (ROCPROF_USE_SYS_YAML_CPP)
find_package(yaml-cpp CONFIG REQUIRED)
else()
add_subdirectory(yaml-cpp EXCLUDE_FROM_ALL)
endif()


target_link_libraries(rocprofiler-sdk-yaml-cpp
INTERFACE $<BUILD_INTERFACE:yaml-cpp::yaml-cpp>)
target_include_directories(
rocprofiler-sdk-yaml-cpp
INTERFACE $<BUILD_INTERFACE:${PROJECT_SOURCE_DIR}/external/yaml-cpp/include>)
INTERFACE yaml-cpp::yaml-cpp)

if (NOT ROCPROF_USE_SYS_YAML_CPP)
target_include_directories(
rocprofiler-sdk-yaml-cpp
INTERFACE $<BUILD_INTERFACE:${PROJECT_SOURCE_DIR}/external/yaml-cpp/include>)
endif()

# checkout submodule if not already checked out or clone repo if no .gitmodules file
rocprofiler_checkout_git_submodule(
Expand Down
Loading