-
Notifications
You must be signed in to change notification settings - Fork 22
CI: Fix failures on forked PRs and centralize Docker image config #380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Fix failures on forked PRs and centralize Docker image config #380
Conversation
|
If you like, I can test this on #369 when ready. |
.github/workflows/rocm-ci.yml
Outdated
| CALC_LEVEL="3" | ||
| elif [[ "${{ github.event_name }}" == "pull_request" && "${{ github.base_ref }}" == "dev" ]]; then | ||
| echo "::notice::PR targeting dev detected. Forcing Test Level to 3." | ||
| CALC_LEVEL="3" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is 1 to match Jenkins logic.
Actually, desired logic is to distinct 3 situations:
- level 3 for push to any dev
- level 3 (may change independently from push to dev) for push to any monitored branch.
- level 1 for PR to any monitored branch
but it may be further development
|
As far as I can tell, the docker image is not set correctly yet for forked PRs, even with this PR merged. See e.g. https://github.com/ROCm/TransformerEngine/actions/runs/19716553519/job/56491482864?pr=369: |
|
You have to merge dev branch yaml to your fork |
|
It's working now - I merged the dev branch locally, but then pushed to the wrong repo 🤦 . Sorry for the confusion. |
Description:
This PR addresses an issue where the TransformerEngine CI workflow fails when triggered from forked repositories. GitHub Actions security policies prevent forked PRs from accessing repository variables (
vars), causing the Docker image name to resolve to an empty string duringdocker pull.Changes:
Introduced
ci/ci_config.json:Updated
Select Docker Image Tagstep in CI workflow:${{ vars }}context.ci/docker_config.jsondynamically from the upstreamdevbranch viacurl.jqto parse the JSON and populate the necessary environment variables.Benefits:
devbranch instantly propagates the new image to all release branches (since they fetch the config dynamically), eliminating the need to cherry-pick image tag updates across multiple branches.