Skip to content

Conversation

@cj401-amd
Copy link

@cj401-amd cj401-amd commented Jun 20, 2025

  • rocprofiler_configure is exposed to initialized rocprofiler-sdk to trace HIP events as it is required by rocprofiler-sdk
  • enable a previously skipped test as rocprofiler-sdk does not cause OOMs any more c8184a8
  • give more appropriate warning message when using PGLE with rocprofiler-sdk

@cj401-amd cj401-amd requested a review from charleshofer June 20, 2025 22:30
@cj401-amd cj401-amd requested a review from a team as a code owner June 20, 2025 22:30
GetPjrtApi;
MosaicGpuCompile;
MosaicGpuUnload;
rocprofiler_configure;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing this here won't do anything since we don't build from this jaxlib code anymore (we just use this repo for its unit tests). You'll need to create a patch file that performs this change, and then stick it in jax_rocm_plugin/third_party/jax in the plugin repo and then add the path to the patch file to the workspace.bzl file under the patches section.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now with rocprofiler_force_configure(), this might not be needed anymore.

Copy link
Collaborator

@charleshofer charleshofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the test skip is fine though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants