Skip to content

add rocprofiler_configure as a global #479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: rocm-jaxlib-v0.6.0
Choose a base branch
from
Open

add rocprofiler_configure as a global #479

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7fb6227
add rocprofiler_configure as a global
cj401-amd May 21, 2025
4a90d34
uncomment test causes OOMs
cj401-amd Aug 7, 2025
ec929e0
remove @unittest.skip('Test causes OOMs') as rocprofiler-sdk has no s…
cj401-amd Aug 7, 2025
0c17ba1
give more appropriate warning message when using PGLE with rocprofile…
cj401-amd Aug 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions jaxlib/tools/gpu_version_script.lds
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ VERS_1.0 {
GetPjrtApi;
MosaicGpuCompile;
MosaicGpuUnload;
rocprofiler_configure;
Copy link
Collaborator

@charleshofer charleshofer Aug 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing this here won't do anything since we don't build from this jaxlib code anymore (we just use this repo for its unit tests). You'll need to create a patch file that performs this change, and then stick it in jax_rocm_plugin/third_party/jax in the plugin repo and then add the path to the patch file to the workspace.bzl file under the patches section.

Copy link
Author

@cj401-amd cj401-amd Aug 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now with rocprofiler_force_configure(), this might not be needed anymore.

};

local:
Expand Down
3 changes: 1 addition & 2 deletions tests/profiler_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,8 +244,7 @@ def _check_xspace_pb_exist(self, logdir):
path = os.path.join(logdir, 'plugins', 'profile', '*', '*.xplane.pb')
self.assertEqual(1, len(glob.glob(path)),
'Expected one path match: ' + path)

@unittest.skip("Test causes OOMs")

@unittest.skipIf(not (portpicker and profiler_client and tf_profiler),
"Test requires tensorflow.profiler and portpicker")
def testSingleWorkerSamplingMode(self, delay_ms=None):
Expand Down