Testing attach test change to see if hang still occurs#1054
Closed
Testing attach test change to see if hang still occurs#1054
Conversation
- This pairs with another commit in rocprofiler-sdk to fully function - Add ptrace entry points for tool attachment - API tracing works at this commit - Queue tracing not supported yet
- Remove hardcode for loading of tool library - Make invoke registration functions public again
- Adds ability to trace with queues during attachment - Must be paired with updated rocprofiler-sdk
- Must be paired with commit in rocprofiler-sdk
- Register will load the prestore library and provide entrypoints to sdk
- This change must be paired with a change in rocprofiler-register to fully function. - API tracing works at this commit - Queue tracing not supported yet
- Add option attach-duration-msec for attachment
…ash when iterating queues
- Adds ability to trace with queues during attachment - Must be paired with updated rocprofiler-register
- Significant changes to force exported interfaces back to C - Fixes bug with unknown agents at attachment - Code objects' names may still be incorrect
- Kernel traces will now have names and all other information for launches - Add capture of hsa_executable to the queue library - Various logging improvements
- Must be paired with commit from rocprofiler-register - Massive overhaul of code organization in prestore library - Separates registrations for different object types - Sets up future changes for initialization
- Removes linkage to prestore library from sdk
- This commit is NONFUNCTIONAL - Changes around structure to remove classes - Seperate C linkage where needed - Still needs updates to register for correct usage
- This commit is NONFUNCTIONAL - Changes rocprofiler_register to handle dispatch table from attach library. - Still needs changes in SDK with dispatch table usage
- This commit is NONFUNCTIONAL
- Remove cross dependency into rocprofiler-sdk, fixes build on some systems
- formatting - proper signature of register_functor for rocprofiler-sdk-attach library callback - remove get_dispatch_registration_table()
Co-authored-by: Jonathan R. Madsen <jrmadsen@users.noreply.github.com>
github-actions
bot
added
documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Technical Details
Test Plan
Test Result
Submission Checklist