Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
81 commits
Select commit Hold shift + click to select a range
d4c8c32
attach: milestone: API tracing
meserve-amd May 30, 2025
c6f8c79
attach: cleanup
meserve-amd Jun 30, 2025
ca06d8a
attach: proxy queue first draft
meserve-amd Jul 8, 2025
2706d4a
attach: prestore overhaul
meserve-amd Jul 30, 2025
ed7bb60
attach: add dispatch table rework
meserve-amd Aug 11, 2025
0b0bc17
attach: formatting and cleanup
meserve-amd Aug 11, 2025
43ad9b6
attach: revise dispatch table scheme
meserve-amd Aug 12, 2025
f16808c
attach: formatting
meserve-amd Aug 12, 2025
5561365
attach: milestone: API tracing
meserve-amd May 30, 2025
be39e10
attach: cleanup and comments
meserve-amd Jun 23, 2025
6df0ded
attach: Formatting and crash fixes
itrowbri Jun 25, 2025
f9fd496
attach: add attach duration
meserve-amd Jun 30, 2025
238ba2c
Formatting + sglang hang fix via signal handling
itrowbri Jul 2, 2025
2f7fa75
Changed FATAL_IF to DFATAL_IF for scratch_memory due to persistent cr…
itrowbri Jul 8, 2025
b72f27c
attach: proxy queue first draft
meserve-amd Jul 8, 2025
8da2fd2
Allow null agents for scratch output
itrowbri Jul 9, 2025
c405d72
attach: improve queue library interface
meserve-amd Jul 23, 2025
738cd2e
attach: add code_object support
meserve-amd Jul 24, 2025
2d36ac0
attach: rename queue library to prestore
meserve-amd Jul 29, 2025
1e7fd1b
attach: prestore overhaul
meserve-amd Jul 30, 2025
59fc30d
attach: add prestore dispatch table
meserve-amd Aug 12, 2025
c308948
attach: cleanup
meserve-amd Aug 12, 2025
9ea6c09
attach: formatting
meserve-amd Aug 12, 2025
706868d
attach: fix input prompt not appearing
meserve-amd Aug 12, 2025
fe90a29
attach: fix component name in cmake
meserve-amd Aug 12, 2025
8e06fb7
attach: revert change to export level
meserve-amd Aug 12, 2025
032633f
Make prestore API public
tcgu-amd Aug 14, 2025
e9769b3
attach: update sdk attachment library WIP
meserve-amd Aug 26, 2025
5c89435
attach: update register with dispatch table WIP
meserve-amd Sep 1, 2025
82780f4
attach: dispatch table wip
meserve-amd Sep 4, 2025
7287528
attach: move attach component into core
meserve-amd Sep 8, 2025
e146063
attach: rename to rocprofv3-attach
meserve-amd Sep 8, 2025
e2e8d59
attach: add callbacks for new queues and code objects
meserve-amd Sep 8, 2025
8545f87
attach: finish dispatch table implementation
meserve-amd Sep 9, 2025
2edf216
attach: add cmake variable for attachment support
meserve-amd Sep 9, 2025
227f765
feat: Add --attach alias for rocprofv3 with comprehensive attachment …
claude Sep 9, 2025
22c4759
Documentation Update
Sep 9, 2025
b678c54
attach: make attach script callable
meserve-amd Sep 9, 2025
361b51e
Added ROCPROFILER_REGISTER_ATTACHMENT_TOOL_LIB to remove hardcoded name
Sep 9, 2025
e7d24cc
attach: revert metrics library path changes
meserve-amd Sep 9, 2025
da61db4
Generic Attachment in Register (#942)
itrowbri Sep 10, 2025
5717db1
Add second param to attach call in rocprof register
Sep 11, 2025
ed73f87
Add experimental reattachment support for ROCprofiler-SDK
Sep 12, 2025
42156a8
Fix misc clang-tidy warnings/errors
jrmadsen Sep 13, 2025
6dbbd21
CMake Option and Environment Variable Updates
jrmadsen Sep 13, 2025
e3951a4
Source reorganization
jrmadsen Sep 13, 2025
4cb3364
Formatting + new lines at EOF
jrmadsen Sep 13, 2025
9ad3f53
Fix flake8 F841: local variable is assigned to but never used
jrmadsen Sep 13, 2025
4c28b0b
Update attachment test
jrmadsen Sep 14, 2025
d355e6d
Rework implementation
jrmadsen Sep 14, 2025
0329fec
Handle re-attachment options
jrmadsen Sep 15, 2025
28a47c3
Fix support for tools w/o rocprofiler_configure_attach
jrmadsen Sep 15, 2025
641b84e
attach: remove unknown agent handling
meserve-amd Sep 15, 2025
fe3f30d
attach: add error for attaching without library loaded
meserve-amd Sep 16, 2025
b4f0606
attach: revise version numbering
meserve-amd Sep 16, 2025
0ef2fec
attach: register header revisions
meserve-amd Sep 16, 2025
c51c1ec
attach: clang format register
meserve-amd Sep 16, 2025
7833050
attach: formatting
meserve-amd Sep 16, 2025
fc77db1
attach: fix build failure
meserve-amd Sep 16, 2025
06767f9
attach: revise register library detection
meserve-amd Sep 16, 2025
0c8bd6f
Update rocprofiler-register and attach library
jrmadsen Sep 16, 2025
238227f
Bump rocprofiler-register version to 0.6.0 + AnyNewerVersion
jrmadsen Sep 16, 2025
2666ae5
Fix output support for rocprofiler-sdk-tool
jrmadsen Sep 16, 2025
88d1896
Fix formatting
jrmadsen Sep 16, 2025
2a4e0b4
Fix clang tidy errors
jrmadsen Sep 16, 2025
8a5b0bd
Misc rocprofiler-sdk-attach fixes
jrmadsen Sep 16, 2025
207eb12
attach: add sigint handling to attach python
meserve-amd Sep 16, 2025
c211413
tool README.md formatting
meserve-amd Sep 16, 2025
b0cdba9
Fix buffered output issue
jrmadsen Sep 16, 2025
2dd70b6
attach: add errors for tool attach
meserve-amd Sep 16, 2025
ffc06d1
CI Fixes
bwelton Sep 16, 2025
08dae6b
Rework tests
jrmadsen Sep 17, 2025
4063c01
attach: improve library loading in rocprofv3 attach
meserve-amd Sep 17, 2025
3b8c13b
formatting
jrmadsen Sep 17, 2025
3c8d45e
Update tests to use pytest framework
jrmadsen Sep 17, 2025
571deb9
Fix test_attachment_hsa_api_trace
jrmadsen Sep 17, 2025
90c0d6e
attach: catch ctypes exceptions
meserve-amd Sep 17, 2025
29c2891
attach: fix leak in registration
meserve-amd Sep 17, 2025
268c791
attach: fix sanitizer tests
meserve-amd Sep 17, 2025
3ad8a16
attach: fix sanitizer tests further
meserve-amd Sep 17, 2025
b01f839
Testing attachment app
itrowbri Sep 18, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion projects/rocprofiler-register/VERSION
Original file line number Diff line number Diff line change
@@ -1 +1 @@
0.5.0
0.6.0
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ configure_package_config_file(
write_basic_package_version_file(
${PROJECT_BINARY_DIR}/${CMAKE_INSTALL_LIBDIR}/cmake/${PROJECT_NAME}/${PROJECT_NAME}-config-version.cmake
VERSION ${PROJECT_VERSION}
COMPATIBILITY SameMinorVersion)
COMPATIBILITY AnyNewerVersion)

install(
FILES
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,10 @@ rocprofiler_register_add_option(ROCPROFILER_REGISTER_BUILD_FMT "Build FMT" ON)
rocprofiler_register_add_option(
ROCPROFILER_REGISTER_DEP_ROCMCORE "DEB and RPM package depend on rocm-core package"
${ROCM_DEP_ROCMCORE})
rocprofiler_register_add_option(
ROCPROFILER_REGISTER_BUILD_DEFAULT_ATTACHMENT
"Enable attachment by default, instead of requiring an environment variable when the application starts"
OFF)

# In the future, we will do this even with clang-tidy enabled
if(ROCPROFILER_REGISTER_BUILD_CI
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,13 @@ typedef struct
/// @var ROCP_REG_EXCESS_API_INSTANCES
/// @brief The same API has been registered too many times
///
/// @var ROCP_REG_INVALID_ARGUMENT
/// @brief Rocprofiler-register API function was provided an invalid argument
///
/// @var ROCP_REG_ATTACHMENT_NOT_AVAILABLE
/// @brief Rocprofiler-register attach or detach was invoked, but the attachment
/// library was not loaded at app startup.
///
typedef enum rocprofiler_register_error_code_t // NOLINT(performance-enum-size)
{
ROCP_REG_SUCCESS = 0,
Expand All @@ -72,6 +79,8 @@ typedef enum rocprofiler_register_error_code_t // NOLINT(performance-enum-size)
ROCP_REG_INVALID_API_ADDRESS,
ROCP_REG_ROCPROFILER_ERROR,
ROCP_REG_EXCESS_API_INSTANCES,
ROCP_REG_INVALID_ARGUMENT,
ROCP_REG_ATTACHMENT_NOT_AVAILABLE,
ROCP_REG_ERROR_CODE_END,
} rocprofiler_register_error_code_t;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,10 @@ set_target_properties(
SOVERSION ${PROJECT_VERSION_MAJOR}
VERSION ${PROJECT_VERSION})

if(ROCPROFILER_REGISTER_BUILD_DEFAULT_ATTACHMENT)
target_compile_definitions(rocprofiler-register PRIVATE ROCP_REG_DEFAULT_ATTACHMENT=1)
endif()

install(
TARGETS rocprofiler-register
DESTINATION ${CMAKE_INSTALL_LIBDIR}
Expand Down
Loading
Loading