Skip to content

[rocprofiler-register] Fix compilation with system fmt/glog #1243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ammallya merged 2 commits into from
Mar 6, 2026
Merged

[rocprofiler-register] Fix compilation with system fmt/glog #1243

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1f582ff
[rocprofiler-register] Fix compilation with system fmt/glog
AngryLoki Oct 4, 2025
4fa2f5b
Merge branch 'develop' into fix-rocprofiler-register-find_package
afzpatel Feb 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion projects/rocprofiler-register/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
cmake_minimum_required(VERSION 3.22.0 FATAL_ERROR)
cmake_minimum_required(VERSION 3.24 FATAL_ERROR)

if(CMAKE_SOURCE_DIR STREQUAL CMAKE_BINARY_DIR AND CMAKE_CURRENT_SOURCE_DIR STREQUAL
CMAKE_SOURCE_DIR)
Expand Down
4 changes: 2 additions & 2 deletions projects/rocprofiler-register/external/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ if(ROCPROFILER_REGISTER_BUILD_GLOG)
set(WITH_UNWIND "none")
add_subdirectory(glog EXCLUDE_FROM_ALL)
else()
find_package(glog REQUIRED)
find_package(glog REQUIRED GLOBAL)
endif()

if(ROCPROFILER_REGISTER_BUILD_FMT)
Expand All @@ -33,5 +33,5 @@ if(ROCPROFILER_REGISTER_BUILD_FMT)
set(FMT_TEST OFF)
add_subdirectory(fmt EXCLUDE_FROM_ALL)
else()
find_package(fmt REQUIRED)
find_package(fmt REQUIRED GLOBAL)
endif()
Loading