[rocprofiler-register] Fix compilation with system fmt/glog#1243
Merged
ammallya merged 2 commits intoROCm:developfrom Mar 6, 2026
Merged
[rocprofiler-register] Fix compilation with system fmt/glog#1243ammallya merged 2 commits intoROCm:developfrom
ammallya merged 2 commits intoROCm:developfrom
Conversation
bwelton
requested changes
Oct 29, 2025
rocprofiler-register provides options to build with system glog and fmt: `-DROCPROFILER_REGISTER_BUILD_GLOG=OFF -DROCPROFILER_REGISTER_BUILD_FMT=OFF`. However these options don't work, because attempt to call ```cmake find_package(glog REQUIRED) ... find_package(fmt REQUIRED) ``` in the **nested** `external/CMakeLists.txt` does not expose glog and fmt to the **parent** `CMakeLists.txt`. To make projects visible, the easiest way is to add `GLOBAL`: ```cmake find_package(glog REQUIRED GLOBAL) ... find_package(fmt REQUIRED GLOBAL) ``` GLOBAL modifier requires CMake >= 3.24, which was not required in ROCm/rocm-systems, but ROCm/rocm-libraries already requires 3.25, so this change should be safe. Closes ROCm#1242.
AngryLoki
force-pushed
the
fix-rocprofiler-register-find_package
branch
from
21232b0 to
1f582ff
Compare
ammarwa
approved these changes
Feb 23, 2026
bwelton
approved these changes
Feb 23, 2026
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rocprofiler-register provides options to build with system glog and fmt:
-DROCPROFILER_REGISTER_BUILD_GLOG=OFF -DROCPROFILER_REGISTER_BUILD_FMT=OFF. However these options don't work, because attempt to callin the nested
external/CMakeLists.txtdoes not expose glog and fmt to the parentCMakeLists.txt. To make projects visible, the easiest way is to addGLOBAL:GLOBALmodifier requires CMake >= 3.24, which was not required inROCm/rocm-systems, butROCm/rocm-librariesalready requires 3.25, so this change should be safe.Closes #1242.
Motivation
Technical Details
Test Plan
Test Result
Submission Checklist