Fix static deinitialization fiasco in destructor#126
Open
systems-assistant[bot] wants to merge 2 commits intodevelopfrom
Open
Fix static deinitialization fiasco in destructor#126systems-assistant[bot] wants to merge 2 commits intodevelopfrom
systems-assistant[bot] wants to merge 2 commits intodevelopfrom
Conversation
…evelop/AngryLoki_aqlprofile/fix-logger
ammallya
pushed a commit
that referenced
this pull request
Aug 7, 2025
* Re-enable OpenMP target and testing * Enable openmp target tests on mi200 jobs * Fix direct self-inclusion of header file * Enable openmp-target testing on vega20 --------- Co-authored-by: Jonathan R. Madsen <jonathanrmadsen@gmail.com> Co-authored-by: Welton, Benjamin <Benjamin.Welton@amd.com> [ROCm/rocprofiler-sdk commit: 2fe63d8]
ammallya
pushed a commit
that referenced
this pull request
Aug 7, 2025
* Adding Integeration tests for later building option * Update CMakeLists.txt --------- Co-authored-by: Ammar ELWazir <aelwazir@amd.com> [ROCm/aqlprofile commit: e4bb0df]
ywang103-amd
pushed a commit
to ywang103-amd/rocm-systems
that referenced
this pull request
Aug 7, 2025
- Add support for RCCL API tracing through rocprofiler-sdk. - Refactored the comm_data code to use the SDK RCCL_API callbacks. - Add a runtime version check for SDK to gate callback enablement, rather than just the compile-time check. - Fixed: SAMPLING_TIMEOUT was not being handled correctly in add_test. [ROCm/rocprofiler-systems commit: af77d93]
jayhawk-commits
pushed a commit
that referenced
this pull request
Aug 18, 2025
[ROCm/hip commit: ef5662a]
ammallya
pushed a commit
that referenced
this pull request
Nov 17, 2025
Signed-off-by: Maisam Arif <Maisam.Arif@amd.com>
ammallya
pushed a commit
that referenced
this pull request
Nov 18, 2025
Signed-off-by: Maisam Arif <Maisam.Arif@amd.com> [ROCm/amdsmi commit: 9d2bbcf]
ammallya
pushed a commit
that referenced
this pull request
Nov 21, 2025
Signed-off-by: Maisam Arif <Maisam.Arif@amd.com> [ROCm/amdsmi commit: 9d2bbcf]
jamessiddeley-amd
pushed a commit
that referenced
this pull request
Dec 11, 2025
* Ensure backward compatibility for fp8 datatypes Signed-off-by: ravaidya <ravaidya@amd.com> * Update code comments Signed-off-by: ravaidya <ravaidya@amd.com> --------- Signed-off-by: ravaidya <ravaidya@amd.com>
ammallya
pushed a commit
that referenced
this pull request
Jan 21, 2026
* final edits * more edits per review * more edits * attempt to fix dead link
ammallya
pushed a commit
that referenced
this pull request
Jan 21, 2026
* final edits * more edits per review * more edits * attempt to fix dead link [ROCm/rocshmem commit: 8a266e6]
ammallya
pushed a commit
that referenced
this pull request
Jan 21, 2026
* Ensure backward compatibility for fp8 datatypes Signed-off-by: ravaidya <ravaidya@amd.com> * Update code comments Signed-off-by: ravaidya <ravaidya@amd.com> --------- Signed-off-by: ravaidya <ravaidya@amd.com> [ROCm/rccl-tests commit: 0abe3c8]
ammallya
pushed a commit
that referenced
this pull request
Jan 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
defines:
logger.h
There is no guarantees for destruction order, but in my case runs after C++ destructors for static objects, trying to lock destroyed mutex.
To fix the deinitialization order, this PR removes custom destructor and replaces it with modern Construct on First Use idiom (a.k.a. Meyers' singletons).
Closes #4
🔁 Imported from ROCm/aqlprofile#5
🧑💻 Originally authored by @AngryLoki