Skip to content

Bump TheRock version to enable hip-tests execution #3034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
litvaOo wants to merge 4 commits into from
Closed

Bump TheRock version to enable hip-tests execution #3034

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ae107ab
Bump TheRock version to enable hip-tests execution
litvaOo Feb 3, 2026
093d6c7
Bump TheRock version to the arch-dependent hip-tests version
litvaOo Feb 3, 2026
a71c34a
Make small formatting change to test the hip-tests trigger
litvaOo Feb 3, 2026
0c414f1
Bump theRock version in test-packages action
litvaOo Feb 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .github/workflows/therock-ci-linux.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ on:
project_to_test:
type: string


permissions:
contents: read

Expand Down Expand Up @@ -38,7 +37,7 @@ jobs:
with:
repository: "ROCm/TheRock"
path: "TheRock"
ref: df5e21e3b8449ade0af12bcf94c0113510e97f6d # 2025-12-30 commit
ref: 83d82a1665a79e3a63ea53df1588e12bb7a75835 # 2026-01-16 commit

- name: Install python deps
run: |
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/therock-ci-windows.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,12 +39,12 @@ jobs:
with:
repository: "ROCm/TheRock"
path: "TheRock"
ref: df5e21e3b8449ade0af12bcf94c0113510e97f6d # 2025-12-30 commit
ref: 83d82a1665a79e3a63ea53df1588e12bb7a75835 # 2026-01-16 commit

- name: Set up Python
uses: actions/setup-python@e797f83bcb11b83ae66e0230d6156d7c80228e7c # v6.0.0
with:
python-version: '3.12'
python-version: "3.12"

- name: Install python deps
run: |
Expand All @@ -70,7 +70,7 @@ jobs:

- uses: iterative/setup-dvc@4bdfd2b0f6f1ad7e08afadb03b1a895c352a5239 # v2.0.0
with:
version: '3.62.0'
version: "3.62.0"

# After other installs, so MSVC get priority in the PATH.
- name: Configure MSVC
Expand Down
12 changes: 6 additions & 6 deletions .github/workflows/therock-test-packages.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ jobs:
sparse-checkout: build_tools
path: "prejob"
repository: "ROCm/TheRock"
ref: df5e21e3b8449ade0af12bcf94c0113510e97f6d # 2025-12-30 commit
ref: 83d82a1665a79e3a63ea53df1588e12bb7a75835 # 2026-01-16 commit

# Checkout failure is possible on Windows, as it's the first job on a GPU test runner.
# Post-job cleanup isn't necessary since no executables are launched in this job.
Expand All @@ -42,7 +42,7 @@ jobs:
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
with:
repository: "ROCm/TheRock"
ref: df5e21e3b8449ade0af12bcf94c0113510e97f6d # 2025-12-30 commit
ref: 83d82a1665a79e3a63ea53df1588e12bb7a75835 # 2026-01-16 commit

- name: "Configuring CI options"
env:
Expand All @@ -52,7 +52,7 @@ jobs:
run: python ./build_tools/github_actions/fetch_test_configurations.py

test_components:
name: 'Test ${{ matrix.components.job_name }}'
name: "Test ${{ matrix.components.job_name }}"
runs-on: ${{ inputs.test_runs_on }}
container:
image: ${{ inputs.platform == 'linux' && 'ghcr.io/rocm/no_rocm_image_ubuntu24_04@sha256:405945a40deaff9db90b9839c0f41d4cba4a383c1a7459b28627047bf6302a26' || null }}
Expand Down Expand Up @@ -84,7 +84,7 @@ jobs:
sparse-checkout: build_tools
path: "prejob"
repository: "ROCm/TheRock"
ref: df5e21e3b8449ade0af12bcf94c0113510e97f6d # 2025-12-30 commit
ref: 83d82a1665a79e3a63ea53df1588e12bb7a75835 # 2026-01-16 commit

- name: Pre-job cleanup processes on Windows
if: ${{ runner.os == 'Windows' }}
Expand All @@ -95,10 +95,10 @@ jobs:
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
with:
repository: "ROCm/TheRock"
ref: df5e21e3b8449ade0af12bcf94c0113510e97f6d # 2025-12-30 commit
ref: 83d82a1665a79e3a63ea53df1588e12bb7a75835 # 2026-01-16 commit

- name: Run setup test environment workflow
uses: './.github/actions/setup_test_environment'
uses: "./.github/actions/setup_test_environment"
with:
ARTIFACT_RUN_ID: ${{ env.ARTIFACT_RUN_ID }}
ARTIFACT_GROUP: ${{ inputs.amdgpu_families }}
Expand Down
3 changes: 1 addition & 2 deletions projects/hip-tests/catch/unit/assertion/assert.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,6 @@ bool isAbortOnErrorEnabled() {
* - HIP_VERSION >= 5.2
*/
TEST_CASE("Unit_Assert_Positive_Basic_KernelPass") {

#ifdef NDEBUG
HipTest::HIP_SKIP_TEST("Assertions are disabled on this build.");
return;
Expand Down Expand Up @@ -116,7 +115,6 @@ TEST_CASE("Unit_Assert_Positive_Basic_KernelPass") {
* - HIP_VERSION >= 5.2
*/
TEST_CASE("Unit_Assert_Positive_Basic_KernelFail") {

#ifdef NDEBUG
HipTest::HIP_SKIP_TEST("Assertions are disabled on this build.");
return;
Expand Down Expand Up @@ -146,6 +144,7 @@ TEST_CASE("Unit_Assert_Positive_Basic_KernelFail") {
#endif
}


/**
* End doxygen group DeviceLanguageTest.
* @}
Expand Down
Loading