Bump TheRock version to enable hip-tests execution#3034
Closed
Bump TheRock version to enable hip-tests execution#3034
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the TheRock CI GitHub Actions workflows to use a newer TheRock commit that enables HIP tests and aligns some minor YAML style details.
Changes:
- Bump TheRock checkout ref in the Windows CI workflow to commit
83d82a1665a79e3a63ea53df1588e12bb7a75835(2026-01-16) and normalize string quoting forpython-versionand DVCversion. - Bump TheRock checkout ref in the Linux CI workflow to the same commit, ensuring both platforms run against the same TheRock revision.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.github/workflows/therock-ci-windows.yml |
Updates TheRock ref to the new commit and switches single quotes to double quotes for python-version and DVC version, keeping behavior the same while pointing CI to the HIP-enabled TheRock revision. |
.github/workflows/therock-ci-linux.yml |
Updates TheRock ref to the same new commit and removes a redundant blank line, ensuring Linux CI uses the HIP-enabled TheRock version consistently with Windows. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
6b3ebdc to
093d6c7
Compare
Collaborator
|
Please see #3020. That PR will accomplish what you want to do. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
We want to enable the hip-tests on TheRock for our repository. This PR bumps the version of TheRock dependency in github actions
Technical Details
Only changes the checkout step of TheRock to the commit from 2026-01-16, ROCm/TheRock@83d82a1, which is enabling hip-tests and makes them target-dependent
JIRA ID
NA
Test Plan
TheRock tests should start and finish successfully
Test Result
Waiting for CI result
Submission Checklist