Skip to content

Bump TheRock version to enable hip-tests execution#3034

Closed
litvaOo wants to merge 4 commits intodevelopfrom
dev/amd/dlytovch/bump-therock-version
Closed

Bump TheRock version to enable hip-tests execution#3034
litvaOo wants to merge 4 commits intodevelopfrom
dev/amd/dlytovch/bump-therock-version

Conversation

@litvaOo
Copy link
Contributor

@litvaOo litvaOo commented Feb 3, 2026

Motivation

We want to enable the hip-tests on TheRock for our repository. This PR bumps the version of TheRock dependency in github actions

Technical Details

Only changes the checkout step of TheRock to the commit from 2026-01-16, ROCm/TheRock@83d82a1, which is enabling hip-tests and makes them target-dependent

JIRA ID

NA

Test Plan

TheRock tests should start and finish successfully

Test Result

Waiting for CI result

Submission Checklist

Copilot AI review requested due to automatic review settings February 3, 2026 09:30
@litvaOo litvaOo requested a review from a team as a code owner February 3, 2026 09:30
@github-actions github-actions bot added the github actions Pull requests that update GitHub Actions code label Feb 3, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the TheRock CI GitHub Actions workflows to use a newer TheRock commit that enables HIP tests and aligns some minor YAML style details.

Changes:

  • Bump TheRock checkout ref in the Windows CI workflow to commit 83d82a1665a79e3a63ea53df1588e12bb7a75835 (2026-01-16) and normalize string quoting for python-version and DVC version.
  • Bump TheRock checkout ref in the Linux CI workflow to the same commit, ensuring both platforms run against the same TheRock revision.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.github/workflows/therock-ci-windows.yml Updates TheRock ref to the new commit and switches single quotes to double quotes for python-version and DVC version, keeping behavior the same while pointing CI to the HIP-enabled TheRock revision.
.github/workflows/therock-ci-linux.yml Updates TheRock ref to the same new commit and removes a redundant blank line, ensuring Linux CI uses the HIP-enabled TheRock version consistently with Windows.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@litvaOo litvaOo force-pushed the dev/amd/dlytovch/bump-therock-version branch from 6b3ebdc to 093d6c7 Compare February 3, 2026 10:22
@litvaOo litvaOo requested a review from a team as a code owner February 3, 2026 11:32
@jayhawk-commits
Copy link
Collaborator

Please see #3020. That PR will accomplish what you want to do.

@jayhawk-commits jayhawk-commits deleted the dev/amd/dlytovch/bump-therock-version branch February 3, 2026 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

github actions Pull requests that update GitHub Actions code organization: ROCm project: hip-tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants