Update Triton to include ld.lld path detection fix using rocm-sdk command #908
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves the AMD backend's
path_to_rocm_lld()function to automatically detect the ROCm HIP linker (ld.lld) in more installation scenarios, particularly for ROCm SDK installations whererocm-sdkcommand is available.Currently, Triton fails to locate
ld.lldunless theTRITON_HIP_LLD_PATHenvironment variable is explicitly set, even when ROCm is correctly installed and available in the system PATH. This affects users with non-standard ROCm installation paths, particularly those usingrocm-sdk.Related issue: ROCm/TheRock#2006
Changes
Added ROCM_PATH environment variable support: Check
ROCM_PATH/llvm/bin/ld.lldif the variable is setAdded rocm-sdk command detection: Run
rocm-sdk path --rootto discover SDK-based ROCm installationsTesting
Tested on ROCm 7.10.0 with ROCm SDK installation where
ld.lldis located at$(rocm-sdk path --root)/llvm/bin/ld.lld. The fix successfully detects the linker without requiring manualTRITON_HIP_LLD_PATHexport.Checklist:
pre-commit run --from-ref origin/main --to-ref HEAD.Testing:
Lit tests: