Skip to content

Update Triton to include ld.lld path detection fix using rocm-sdk command #908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main_perf
Choose a base branch
from
Open

Update Triton to include ld.lld path detection fix using rocm-sdk command #908

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
06f1ee9
Improve ld.lld path detection for ROCm SDK custom path installation
adityas-amd Nov 22, 2025
0ad2698
Improve ld.lld path detection for ROCm SDK custom path installation
adityas-amd Nov 22, 2025
e44c951
Improve ld.lld path detection for ROCm SDK custom path installation
adityas-amd Nov 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions third_party/amd/backend/compiler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,6 +171,20 @@ def path_to_rocm_lld():
lld = Path(lld_env_path)
if lld.is_file():
return lld
# Check ROCM_PATH environment variable
rocm_path = os.getenv("ROCM_PATH")
if rocm_path is not None:
lld = Path(rocm_path) / "llvm/bin/ld.lld"
if lld.is_file():
return lld
# Try rocm-sdk command
try:
sdk_root = subprocess.check_output(["rocm-sdk", "path", "--root"], text=True).strip()
lld = Path(sdk_root) / "llvm/bin/ld.lld"
if lld.is_file():
return lld
except (FileNotFoundError, subprocess.CalledProcessError):
pass
# Check backend for ld.lld (used for pytorch wheels)
lld = Path(__file__).parent / "llvm/bin/ld.lld"
if lld.is_file():
Expand Down
Loading