Skip to content

Skip validation when custom library#67

Merged
eelcoj merged 2 commits intomainfrom
custom-icons-regression
Apr 17, 2025
Merged

Skip validation when custom library#67
eelcoj merged 2 commits intomainfrom
custom-icons-regression

Conversation

@eelcoj
Copy link
Copy Markdown
Collaborator

@eelcoj eelcoj commented Mar 21, 2025

Closes #66 (comment)

# approach is preferred over `File.read` because `gsub_file` is properly stubbed
# in generator tests, while `File.read` would fail in the test environment.
#
def file_contains?(path, content)
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If someone reads this and knows a cleaner way to do this, let me know.

All this is needed for is to make the test not fail.

@eelcoj eelcoj merged commit 51e7175 into main Apr 17, 2025
3 checks passed
@eelcoj eelcoj deleted the custom-icons-regression branch April 17, 2025 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Regression in v1.2.0: custom libraries cannot be initialized

1 participant