Skip to content

Add APKEditor features #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Raival-e merged 10 commits into from
Jan 29, 2025
Merged

Add APKEditor features #58

Raival-e merged 10 commits into from
Jan 29, 2025

Conversation

@AbhiTheModder
Copy link
Contributor

@AbhiTheModder AbhiTheModder commented Jan 28, 2025 •
edited
Loading

  • Anti-Split ( Split APKs to APK )
  • APK Sign
  • Fix ru un-changed strings

Note:

  • If possible suggest changing the icon of PreferencesManager.GeneralPrefs.signApk to a more suitable one.

@AbhiTheModder
feat: Add APKEditor and APK merge functionality
3216cf7
@AbhiTheModder
fix: fix merge output filename
14ba120
@AbhiTheModder
feat: add sign apk option
84a7f7b 
Adds a new option in the preferences to sign APKs after operations like Anti-Split (merge).
This option can be enabled or disabled in the General settings.
If enabled, the APK will be signed using a default (test) keystore after the merge operation is completed.
@AbhiTheModder
Copy link
Contributor Author

AbhiTheModder commented Jan 28, 2025 •
edited
Loading

Originally, I planned to work on the GUI for REAndroid/APKEditor and explored various file explorer libraries. I came across your library and was impressed. I noticed issue #54 tagged as an enhancement, and it seems you're interested in integrating it into this project, which I hadn't expected (generally not every file explorer likes to implement APK Editing features). I've currently implemented a few things. Please provide feedback and your opinion if you're willing to continue.

@Raival-e
Copy link
Owner

Raival-e commented Jan 28, 2025

I appreciate your work!

I get a lot of suggestions (as seen in issues page). I really want to implement them all while I can, unfortunately however, I'm not familiar with how some of them can be done, that is why I've been focusing on adding the basic features of a file explorer, and then I'd look on the more advance features. I want this File Explorer to be just as reliable as other closed-source alternatives.

I noticed issue #54 tagged as an enhancement, and it seems you're interested in integrating it into this project

Although it is tagged as enhancement, I wouldn't have probably implemented it any time soon, mainly because I'm not familiar these features, so it would need some research first. Speaking of APK editing, may I ask you what is that APKEditor.jar library and where is it from?

@AbhiTheModder
Copy link
Contributor Author

AbhiTheModder commented Jan 28, 2025 •
edited
Loading

Speaking of APK editing, may I ask you what is that APKEditor.jar library and where is it from?

https://github.com/REAndroid/APKEditor.git

@Raival-e
Copy link
Owner

Raival-e commented Jan 28, 2025

Could you use string resources instead of the hard-coded strings. Everything else seems good!

@Raival-e
Copy link
Owner

Raival-e commented Jan 28, 2025

should I merge this now? or there is something else you want to add?

@AbhiTheModder
Copy link
Contributor Author

AbhiTheModder commented Jan 29, 2025 •
edited
Loading

should I merge this now? or there is something else you want to add?

Change hard-coded strings to string resources. Additionally, I need to find a solution for handling the minifyR8Release job for the jar. Currently, it significantly increases the application size, and with minification, the app fails to load.

Edit: Done

@AbhiTheModder
use string resources instead of the hard-coded strings
1a78b85
@AbhiTheModder
feat: add proguard rules to keep content and interface
48eb99d 
Added rules to `proguard-rules.pro` to keep classes in `android.content.**` and all interface names. This is for the R8 compiler that shrinks and obfuscates code.
@AbhiTheModder AbhiTheModder marked this pull request as ready for review January 29, 2025 04:42
@Raival-e
Copy link
Owner

Raival-e commented Jan 29, 2025

I need to find a solution for handling the minifyR8Release job for the jar. Currently, it significantly increases the application size

I was thinking the same. let me know when you're done.

@AbhiTheModder
Copy link
Contributor Author

AbhiTheModder commented Jan 29, 2025 •
edited
Loading

I need to find a solution for handling the minifyR8Release job for the jar. Currently, it significantly increases the application size

I was thinking the same. let me know when you're done.

Ah it's done now (in 48eb99d), ready for merge.

@Raival-e Raival-e merged commit 6338715 into Raival-e:master Jan 29, 2025
1 check passed
@Raival-e Raival-e mentioned this pull request Apr 3, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AbhiTheModder @Raival-e