Skip to content

Fix crash on simplified to no vertices #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RamType0 merged 2 commits into from
Jun 25, 2025

Allow set target triangle count to 0

13c8747
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

Fix crash on simplified to no vertices #24

Allow set target triangle count to 0
13c8747
Select commit
Loading
Failed to load commit list.
GitHub Actions / playmode on 6000.0.51f1 Test Results completed Jun 25, 2025 in 0s

✅ playmode on 6000.0.51f1 Test Results - 9/9 - Passed in 0.775s

✅ playmode-results.xml - 9/9 - Passed in 0.775s

Details

✅ playmode-results.xml - 9/9 - Passed in 0.775s
  • ✅ Meshia.MeshSimplification.Tests.MeshSimplifierTests.ShouldSimplifyPrimitive - 3/3 - Passed in 0.402s
    • ✅ ShouldSimplifyPrimitive(Sphere) - Passed in 0.341s
    • ✅ ShouldSimplifyPrimitive(Capsule) - Passed in 0.055s
    • ✅ ShouldSimplifyPrimitive(Cylinder) - Passed in 0.007s
  • ✅ Meshia.MeshSimplification.Tests.MeshSimplifierTests.ShouldSimplifyPrimitiveIncrementally - 3/3 - Passed in 0.147s
    • ✅ ShouldSimplifyPrimitiveIncrementally(Sphere) - Passed in 0.074s
    • ✅ ShouldSimplifyPrimitiveIncrementally(Capsule) - Passed in 0.063s
    • ✅ ShouldSimplifyPrimitiveIncrementally(Cylinder) - Passed in 0.010s
  • ✅ Meshia.MeshSimplification.Tests.MeshSimplifierTests.ShouldSimplifyPrimitiveWithDuplicatedSubMeshes - 3/3 - Passed in 0.169s
    • ✅ ShouldSimplifyPrimitiveWithDuplicatedSubMeshes(Sphere) - Passed in 0.082s
    • ✅ ShouldSimplifyPrimitiveWithDuplicatedSubMeshes(Capsule) - Passed in 0.075s
    • ✅ ShouldSimplifyPrimitiveWithDuplicatedSubMeshes(Cylinder) - Passed in 0.013s
View more details on GitHub Actions