feat: insert in move mode #390
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This feels a bit rough while move mode disconnects from the connection you just inserted at.
microbit-matt-hillsdon
force-pushed
the
insert-move-mode
branch
from
76ed950 to
86df444
Compare
rachel-fenichel
approved these changes
Apr 8, 2025
Collaborator
|
If you'll mark it ready for review, I can merge this one. |
Contributor
Author
|
@rachel-fenichel I merged main in and despite #392 you don't get the drag preview. I think this breaks insertion as unless you move away and back everything lands on the workspace, so not ready to merge. |
Collaborator
|
Superseded by #406 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feels a bit rough while move mode disconnects from the connection you just inserted at.
@rachel-fenichel not ready to be merged but sharing in case it's useful for current work. Feel free to close.
An interesting issue is what to do with undo. At the moment the insert and the undo are separate but that feels wrong as the insert feels transient now until confirmed in position. Relatedly, undo during a move causes tragic errors (in common with most other non-move actions).
Demo: https://insert-move-mode.blockly-keyboard-experimentation.pages.dev/