Skip to content

feat: insert in move mode #390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
microbit-matt-hillsdon wants to merge 2 commits into from
Closed

feat: insert in move mode #390

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
86df444
feat: insert in move mode
microbit-matt-hillsdon Apr 7, 2025
451b080
Merge branch 'main' into insert-move-mode
microbit-matt-hillsdon Apr 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/actions/enter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,14 +22,18 @@ import type {

import * as Constants from '../constants';
import type {Navigation} from '../navigation';
import {Mover} from './mover';

const KeyCodes = BlocklyUtils.KeyCodes;

/**
* Class for registering a shortcut for the enter action.
*/
export class EnterAction {
constructor(private navigation: Navigation) {}
constructor(
private mover: Mover,
private navigation: Navigation,
) {}

/**
* Adds the enter action shortcut to the registry.
Expand Down Expand Up @@ -149,6 +153,8 @@ export class EnterAction {
this.navigation.focusWorkspace(workspace);
// eslint-disable-next-line @typescript-eslint/no-non-null-assertion
workspace.getCursor()?.setCurNode(ASTNode.createBlockNode(newBlock)!);

this.mover.startMove(workspace);
}

/**
Expand Down
2 changes: 1 addition & 1 deletion src/navigation_controller.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ export class NavigationController {

exitAction: ExitAction = new ExitAction(this.navigation);

enterAction: EnterAction = new EnterAction(this.navigation);
enterAction: EnterAction = new EnterAction(this.mover, this.navigation);

actionMenu: ActionMenu = new ActionMenu(this.navigation);

Expand Down