fix: insert then cancel with workspace selected #626
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The workspace selection case is broken
microbit-matt-hillsdon
requested review from
RoboErikG
and removed request for
a team
microbit-matt-hillsdon
force-pushed
the
fix-ws-insert-cancel
branch
from
18e1d4f to
73bd75d
Compare
microbit-matt-hillsdon
force-pushed
the
fix-ws-insert-cancel
branch
from
73bd75d to
886c4d4
Compare
microbit-matt-hillsdon
force-pushed
the
fix-ws-insert-cancel
branch
from
886c4d4 to
3ee4f86
Compare
Contributor
Author
|
Fixed conflicts (just test imports). |
Contributor
Author
Collaborator
Contributor
Author
RoboErikG
approved these changes
Jul 7, 2025
Contributor
There was a problem hiding this comment.
Got it and I see #625 is already in. Sorry for the delay, I was out last week. I can merge once the conflicts are resolved.
This looks good for kb-exp, though I'm going to file a bug for us to rethink the mover APIs before this gets merged into Core as this feels a bit messy. Let us know if you have any suggestions!
Contributor
Author
|
Something else to ponder at the same time is scenarios like #635. Conflicts fixed, please consider this an unsolicited ad for git rerere. ➜ blockly-keyboard-experimentation git:(fix-ws-insert-cancel) ✗ git merge main
...
Resolved 'src/actions/move.ts' using previous resolution.
Resolved 'src/actions/mover.ts' using previous resolution.
... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #623
The implementation conflated having no insertStartPosition with the block being new. But when the workspace is selected then there is no insert start position even if the block is new. Instead track whether we're inserting or just moving separately.
Demo: https://fix-ws-insert-cancel.blockly-keyboard-experimentation.pages.dev/