-
Notifications
You must be signed in to change notification settings - Fork 13
feat: Add support for acting on workspace comments and icons. #625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
BenHenning
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good, though is it possible to add tests for both comment cases?
Co-authored-by: Ben Henning <[email protected]>
|
This PR fixes #614. |
|
Tests have been added. |
BenHenning
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @gonfunko. LGTM, though happy to take another pass if you'd like. I did have a few suggestions, but I think they're all hopefully non-controversial.
| chai.assert.equal(focusedNodeId, `${this.comment1}_collapse_bar_button`); | ||
| }); | ||
|
|
||
| test('Activate workspace comment button', async function () { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe add a test for toggling to show that it can be expanded.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that'd be better handled in the core workspace comment tests; my goal here is just to ensure that the keyboard nav infrastructure is hooked up to the underlying views/buttons.
|
Feedback from @microbit-grace testing workspace comments nav today:
|
|
Also noticed that comments are not scrolled into view when you navigate to them. |
|
Thanks for the feedback! Agreed that all broadly sounds reasonable; I'll merge this as-is to unblock #626 and address those points in a followup later today. |


In conjunction with RaspberryPiFoundation/blockly#9182, this PR adds support for editing workspace comments, activating their icons via keyboard navigation, and moving them.