fix: Allow workspace comments to be moved in constrained mode. #646
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gonfunko
force-pushed
the
workspace-comment-fast-follows
branch
from
de7aa21 to
7b813cf
Compare
BenHenning
approved these changes
Jul 7, 2025
Collaborator
BenHenning
left a comment
BenHenning
left a comment
There was a problem hiding this comment.
It'd be nice to see at least 1 test that would break without this change, but going ahead and approving to unblock.
gonfunko
force-pushed
the
workspace-comment-fast-follows
branch
from
038c15e to
1a79c16
Compare
BenHenning
approved these changes
Jul 7, 2025
Collaborator
BenHenning
left a comment
BenHenning
left a comment
There was a problem hiding this comment.
Thanks for adding the test!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows workspace comments to be moved in "constrained" mode via the arrow keys without modifiers. Since workspace comments can be placed anywhere, this just passes through to unconstrained movement. This addresses a point of feedback raised in #625.