Skip to content

fix: Allow workspace comments to be moved in constrained mode. #646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gonfunko merged 3 commits into from
Jul 7, 2025
Merged

fix: Allow workspace comments to be moved in constrained mode. #646

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7b813cf
fix: Allow workspace comments to be moved in constrained mode.
gonfunko Jul 7, 2025
1a79c16
chore: Add test for moving workspace comments in constrained mode.
gonfunko Jul 7, 2025
ddeb2a7
refactor: Use arrow wrapper functions in test.
gonfunko Jul 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/actions/mover.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -318,6 +318,10 @@ export class Mover {
const info = this.moves.get(workspace);
if (!info) throw new Error('no move info for workspace');

if (info.draggable instanceof comments.RenderedWorkspaceComment) {
return this.moveUnconstrained(workspace, direction);
}

info.dragger.onDrag(
info.fakePointerEvent('pointermove', direction),
info.totalDelta.clone().scale(workspace.scale),
Expand Down
17 changes: 16 additions & 1 deletion test/webdriverio/test/workspace_comment_test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,7 @@ suite('Workspace comment navigation', function () {
);
});

test('Workspace comments can be moved', async function () {
test('Workspace comments can be moved in unconstrained mode', async function () {
await focusOnWorkspaceComment(this.browser, this.commentId1);

const initialPosition = await this.getCommentLocation(this.commentId1);
Expand All @@ -203,4 +203,19 @@ suite('Workspace comment navigation', function () {
const newPosition = await this.getCommentLocation(this.commentId1);
chai.assert.deepEqual(newPosition, [220, 240]);
});

test('Workspace comments can be moved in constrained mode', async function () {
await focusOnWorkspaceComment(this.browser, this.commentId1);

const initialPosition = await this.getCommentLocation(this.commentId1);
chai.assert.deepEqual(initialPosition, [200, 200]);

await sendKeyAndWait(this.browser, 'm');
await sendKeyAndWait(this.browser, Key.ArrowUp, 2);
await sendKeyAndWait(this.browser, Key.ArrowLeft);
await sendKeyAndWait(this.browser, Key.Enter);

const newPosition = await this.getCommentLocation(this.commentId1);
chai.assert.deepEqual(newPosition, [180, 160]);
});
});