refactor(CSS): move plugin styling from test/index.html to src/index.js
#637
Conversation
The blocklyToolboxDiv class was renamed blocklyToolbox in RaspberryPiFoundation/blockly#8647, fixing RaspberryPiFoundation/blockly#8343. The references in this repository were not updated but are now evidently obsolete: if we wanted them we'd have fixed them by now.
Also apply only to .blocklyToolbox instead of *
Also move them from html to .injectionDiv.
|
@microbit-matt-hillsdon: Please take a look at this and RaspberryPiFoundation/blockly#9201. |
|
I can't enable auto-squash on this but am happy to have it merged on my behalf once successfully reviewed. |
cpcallen
changed the title
test/index.html to src/index.js.test/index.html to src/index.js
|
Rather than having this run at load, can the registering be moved into a (static?) method |
If I recall correctly, this has to be run at load (or in a static method called on load) because you have to call |
|
That's correct, but I think confining it to a static method that needs to be called will avoid the other issues and is helpful on net. |
|
Okay, Maribeth asked me to rebase this and make that change, so I'm also assigning it to myself. |
|
Replaced by #650 (to complete the change while Christopher is offline). |
3 participants
Resolves
Fixes #595.
Proposed Changes
Move styling of:
from
test/index.htmltosrc/index.ts.Additionally, via RaspberryPiFoundation/blockly#9201, move a fix for the toolbox focus styling from the plugin to core.
Reason for Changes
It should not be necessary to manually add styling to projects using the
@blockly/keyboard-navigationplugin in order for the plugin to function as expectd.Test Coverage
Manually verified that there were no obvious styling differences after making these changes.
Additional Information
Much of the styling added to
src/index.ts, particularly the focus-related styling, should be moved to core. Unfortunately because it intersects with the existing styling of rendered elements, it should probably be done by breaking it up and moving it to appropriate places incore/renderers/, rather than just dumping it incore/css.ts, and I'm just not sure where it should all go yet, so in the interest of expediency I am satisfying #595 and will file a separate issue for the move to core.