refactor(CSS): move plugin styling to a static method in index.ts #650
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The blocklyToolboxDiv class was renamed blocklyToolbox in RaspberryPiFoundation/blockly#8647, fixing RaspberryPiFoundation/blockly#8343. The references in this repository were not updated but are now evidently obsolete: if we wanted them we'd have fixed them by now.
Also apply only to .blocklyToolbox instead of *
Also move them from html to .injectionDiv.
gonfunko
approved these changes
Jul 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #595.
This is a rebuild of #637 with a fix for Aaron's request.
After this change, applications that use the plugin will need to call
KeyboardNavigation.registerKeyboardNavigationStyles();once before injection. They do not need to directly copy or create any of the associated CSS.This is not the same behaviour as the original PR, which did not require any calls to registering styles. I made the change because of past issues with accidental re-registration of styles + multiple workspaces.