feat: Improve trust plugin dialog design #2420
Conversation
app/src/main/java/app/revanced/manager/ui/screen/settings/DownloadsSettingsScreen.kt
Outdated
Show resolved
Hide resolved
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
|
Offtopic, but why does it say "ReVanced Manager: ..."? |
|
I think the importance of this screen and dialog is enabling and disabling plugins. Trusting them is a secondary task to achieve that main objective. Strings can be renamed to say "Enable" or "Disable" plugin. And the dialog can mention that enabling the plugin can run arbitrary code and need to be trusted as a "side notice" |
app/src/main/res/values/strings.xml
Outdated
| <string name="downloader_plugin_trust_dialog_title">Trust plugin?</string> | ||
| <string name="downloader_plugin_revoke_trust_dialog_title">Revoke trust?</string> | ||
| <string name="downloader_plugin_trust_dialog_body">Package name: %1$s\nSignature (SHA-256): %2$s</string> | ||
| <string name="downloader_plugin_trust_dialog_body">By continuing you\'ve agreed to running external plugins.\n\nDo not allow any suspicious plugin(s) to be installed as they can run arbitrary code.</string> |
There was a problem hiding this comment.
Sounds like youre signing some legal document. Probably different wording would be better here.
There was a problem hiding this comment.
Also, "plugin(s)" can just be "plugins".
Placeholder representation of the app name |
|
I am not sure what you mean by placeholder. What would be written there if others develop plugins? |
|
The app name of the plugin — for example, the APKMirror plugin would be named ReVanced Manager: APKMirror. This accurately represents what the app is and its purpose. If it were just APKMirror, you wouldn't know it is for ReVanced Manager in the app list, and that it isn't actually by APKMirror. |
|
It should probably say "ReVanced: APKMirror downloader" or "Ushie: Some other downloader" |
|
Would Ushie make sense here? It serves no purpose knowing who the developer is, knowing what app it's for is what makes more sense |
app/src/main/java/app/revanced/manager/ui/screen/settings/DownloadsSettingsScreen.kt
Outdated
Show resolved
Hide resolved
oSumAtrIX
force-pushed
the
compose-dev
branch
3 times, most recently
from
7338157 to
70a6950
Compare
brosssh
force-pushed
the
compose/feat/improve-trust-plugin-dialog
branch
from
ba1271b to
47129cd
Compare
app/src/main/java/app/revanced/manager/ui/screen/settings/DownloadsSettingsScreen.kt
Outdated
Show resolved
Hide resolved
|
Can this be merged? |
|
If the designers are ok with it then yes |
|
What do you think about this? |
I agree. In addition to changing the button to "Enable"/"Disable", I think the other button should be "Cancel" instead of "Dismiss". "Cancel" is already used in other similar dialogs (see the Advanced section in the settings). A new issue is that when using the words "Enable"/"Disable", there is no longer any purpose for the dialog when disabling it. Disabling a plugin inherently means that it will no longer function or run its code. Therefore, I think it would be fitting for the plugins to have a toggle, and the dialog would only appear when the toggle is being enabled. Here is a proposal for the dialog when enabling a plugin: If the goal is to sound somewhat scary, "run arbitrary code" can be substituted with "execute arbitrary code". |
Ushie
force-pushed
the
compose/feat/improve-trust-plugin-dialog
branch
from
2f3ba22 to
1bfdaa9
Compare
Ushie
force-pushed
the
compose/feat/improve-trust-plugin-dialog
branch
from
1bfdaa9 to
d15d7f7
Compare
# app [1.26.0-dev.12](v1.26.0-dev.11...v1.26.0-dev.12) (2025-12-17) ### Features * Improve trust plugin dialog design ([#2420](#2420)) ([0300da9](0300da9))
* feat: add favorites to the file picker & bump version * feat: add supported ABIs to version search query * feat: add settings option to change search engine used for version search queries * feat: update dev build workflow & add dev to verison number * feat: prompt user to enable "Install unknow apps" * feat: remove redundant `Apply` and `Cancel` buttons on theme preview widgets * feat: add setting toggle for patch selection screen version tags * feat: rename `ReVanced Patches` to `Official ReVanced Patches` on the update configuration screen * feat: hide apps that only use universal patches when `Show & allow using universal patches` is toggled off * Update ko strings.xml * Update ko strings.xml * feat: convert existing components using the old file picker to the custom one & add saving plus overwrite warning logic * feat: Manager string localization Update (Vietnamese) * feat: remove redundant `Show other versions` button on the app selection screen for apps that support all versions * feat: redesign patch option screens * feat: remember last directory in custom file picker * feat: add a `Discover patch bundles` system using Brosssh's external bundle API * fix: patch does not exist error with the experimental patcher * feat: improve `Discover patch bundles` UI and add a togglable button for `Prerelease` and `Release` * feat: add a toggle in Developer Options for hiding the `Batter optimization` banner * feat: upstream patcher UI improvements with ReVanced/revanced-manager#2805 * feat: upstreamed app info improvements ReVanced/revanced-manager#2896 * feat: improve downloader plugin trust dialog ReVanced/revanced-manager#2420 * feat: backround bundle update checker with notifications ReVanced/revanced-manager#2561 * feat: fix app icon & and add star history graph * feat: show individual patcher steps in the patcher screen * Update ko strings.xml * Update ko strings.xml * feat: improve experimental patcher * fix: discover patch bundles widget gap * feat: add saved app toggle * feat: improve system installer * ci: replace debug builds in `Dev Builds` workflow with dev builds * ci: fix dev build * feat: app icons for apks in custom file picker & other improvements * feat: switch system installer detection to Ackpine sessions following ReVanced/revanced-manager#2900 * Update ko strings.xml * Update ko strings.xml * feat: manually select a patch bundle from a dialog for patch profiles * Update ko strings.xml * Update ko strings.xml * feat: add a search bar to settings * Update ko strings.xml * feat: add auto downloading for patch bundles in the background w/ a notification, fixes & polishing * feat: fix clarity of a string & add bundle select overrides to saved patched apps * Update ko strings.xml * Update ko strings.xml * fix: readjust the alignment of the discover patch bundles widget * feat: add unique features to `README.md` and finalize everything * fix: wrong date in `CHANGELOG.md` * Added lines and translated Editing and adding missing lines in translation. The lines are taken from the developer version URV 1.7.0. --------- Co-authored-by: BlackGold8282 <[email protected]> Co-authored-by: ann9cht <[email protected]> Co-authored-by: Aleksandr <[email protected]>
Closes #2061