-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
docs: Fix typos and settings order #2785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 6 commits
0a04013
6a52edb
19ba23b
9703fb0
f62bd4e
f12be30
ed7ce0a
6ebab90
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,29 +4,29 @@ Learn how to configure ReVanced Manager. | |
|
|
||
| ## 🔧 Settings | ||
|
|
||
| - **Import & export**: Import or export patch selections, patch options and the signing keystore | ||
| - **Downloads**: Enable or disable ReVanced Manager downloader and manage past downloaded apps here | ||
| - **Import & export**: Import or export patch selections, patch options and the signing keystore | ||
| - **Advanced**: | ||
| - **API URL**: Set the URL of the ReVanced API, ReVanced Manager will use | ||
| - **Disable version compatibility check**: Patching versions of apps the patches are explicitly compatible with is enforced. | ||
| Disabling this will allow patching versions of apps the patches are not explicitly compatible with | ||
| > ⚠️ Warning | ||
| > Patches may fail patching versions they are not explicitly compatible with. | ||
| > Unless you know what you are doing, it is recommended to keep this enabled. | ||
| - **Allow changing patch selection**: The default selection of patches is enforced. | ||
| Enabling this will allow you to change the patch selection | ||
| > ⚠️ Warning | ||
| > Changing the selection may cause unexpected issues. | ||
| > Patches may fail on app versions they are not explicitly compatible with. | ||
| > Unless you know what you are doing, it is recommended to keep this disabled. | ||
| - **Require suggested app version**: Specific versions of apps is enforced based on the patch selection automatically. | ||
| Disabling this will allow you to patch any version of apps | ||
| > ⚠️ Warning | ||
| > Patches not compatible with the selected version of the app will not be used. | ||
| > Unless you know what you are doing, it is recommended to keep this enabled. | ||
| - **Allow universal patches**: Patches that do not specify compatibility with an app explicitly are forcibly disabled. | ||
| - **Allow changing patch selection and options**: The default selection of patches is enforced. | ||
| Enabling this will allow you to change the patch selection | ||
| > ⚠️ Warning | ||
| > Changing the selection may cause unexpected issues. | ||
| > Unless you know what you are doing, it is recommended to keep this disabled. | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. In 1.26.0-dev.7, this option is enabled by default. Is that a bug, or does this warning need to be changed?
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. That is enabled by default yes, this is not "expected", I already notified the team in discord. |
||
| - **Allow using universal patches**: Patches that do not specify compatibility with an app are forcibly disabled. | ||
| Enabling this will allow selecting such patches | ||
| > ⚠️ Warning | ||
| > Universal patches do not specify compatibility with an app explicitly may not work on all apps regardless. | ||
| > Universal patches do not specify compatibility with an app and may not work on all apps regardless. | ||
| > Unless you know what you are doing, it is recommended to keep this disabled. | ||
| - **About**: View more information and links about ReVanced and ReVanced Manager. | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't it better to use version at both places?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In that case the toggle titles will also need to be singular. Currently they are plural ("Use pre-releases")
Also, I think "versions" better reflects that the patches and Manager are constantly updated. There isn't a single pre-release version. Rather, it is constantly changing. Not sure if I'm explaining myself well. I understand your perspective too 😅