Skip to content

Conversation

@LisoUseInAIKyrios
Copy link
Contributor

@LisoUseInAIKyrios LisoUseInAIKyrios commented Oct 12, 2025

Uses a custom icon for the push notification 'small icon'. This icon is shown in the system status bar for all devices:

Lawnchair

If your device uses Android ASOP design then the push notification icon is also changed (the blue icon background in the screenshot below is the system theme for this particular device. The icon background color will match the theme of your device).

ASOP notification day mode

ASOP notification dark mode

But if your device does not follow Android ASOP behavior and it shows a large app icon in push notifications (such as Samsung devices), then that icon will still show the original red/white YouTube logo (That icon cannot be programmatically changed using an in-app setting).

@cyberboh
Copy link
Contributor

Is this PR only applicable to notification icon? How about all toast messages inside the app, e.g toast SB sent segment, toast RYD time out/error, etc?

@LisoUseInAIKyrios
Copy link
Contributor Author

If your device shows the red/white YouTube logo in push notifications or in toast messages, then this change does not change that.

This PR changes the system status bar icon (icon with clock/battery/etc), and changes the push notification icon for devices that don't show a large YT icon with push notifications (Google pixel, all other devices that use ASOP launcher behavior).

For devices that show the large app icon (Samsung, probably other manufacturers as well), the only fix is to add a patch option to permanently change the icon (explained in the linked issue). Will do that later in another PR.

@cyberboh
Copy link
Contributor

If your device shows the red/white YouTube logo in push notifications or in toast messages, then this change does not change that.

Yes, my device shows red YouTube original logo even I applied Custom branding patch and picked revanced branding logo.

@MarcaDian
Copy link
Contributor

MarcaDian commented Oct 12, 2025

<?xml version="1.0" encoding="utf-8"?>
<vector xmlns:android="http://schemas.android.com/apk/res/android"
    android:width="24dp"
    android:height="24dp"
    android:viewportWidth="24"
    android:viewportHeight="24">

    <path
        android:fillColor="#000000"
        android:pathData="M4.62891,3.59375 C4.41406,3.59375,4.21875,3.69922,4.10156,3.875 C3.98828,4.05469,3.96875,4.27734,4.05078,4.46875 C5.40234,7.55078,9.88672,17.7891,10.8047,19.8828 C10.9063,20.1094,11.1289,20.2578,11.3789,20.2578 L12.6211,20.2578 C12.8711,20.2578,13.0938,20.1094,13.1953,19.8828 C14.1133,17.7891,18.5977,7.55078,19.9492,4.46875 C20.0313,4.27734,20.0117,4.05469,19.8984,3.875 C19.7813,3.69922,19.5859,3.59375,19.375,3.59375 L18.5625,3.59375 C18.3867,3.59375,18.2227,3.69531,18.1523,3.85938 C17.4375,5.48828,13.668,14.0703,12.4102,16.9375 C12.3398,17.1016,12.1758,17.207,12,17.207 C11.8242,17.207,11.6602,17.1016,11.5898,16.9375 C10.332,14.0703,6.5625,5.48828,5.84766,3.85938 C5.77734,3.69531,5.61328,3.59375,5.4375,3.59375 Z M7.80859,3.59375 C7.61719,3.59375,7.44141,3.69531,7.34375,3.85938 C7.24609,4.02734,7.24609,4.23047,7.34375,4.39844 C8.31641,6.08203,10.5625,9.96875,11.5352,11.6563 C11.6289,11.8203,11.8086,11.9258,12,11.9258 C12.1914,11.9258,12.3672,11.8203,12.4648,11.6563 C13.4375,9.96875,15.6836,6.08203,16.6563,4.39844 C16.75,4.23047,16.75,4.02734,16.6563,3.85938 C16.5586,3.69531,16.3828,3.59375,16.1914,3.59375 Z M7.80859,3.59375" />
</vector>

@LisoUseInAIKyrios LisoUseInAIKyrios force-pushed the fix/custom_branding_permanent_patch_option branch from d04fecb to c1fd6cb Compare October 12, 2025 13:37
@LisoUseInAIKyrios LisoUseInAIKyrios marked this pull request as ready for review October 12, 2025 14:02
@MarcaDian
Copy link
Contributor

MarcaDian commented Oct 12, 2025

Does this ^ icon look correct?

I don’t use notifications in ReVanced, so I can’t check.

In the status bar shade (dropdown panel), the standard YouTube icon is displayed.

Screenshot_2025-10-12-19-29-54-110_app.revanced.android.youtube-edit.jpg

Screenshot_2025-10-12-19-36-40-060_com.miui.home-edit.jpg

Screenshot_2025-10-12-19-36-27-626_com.miui.home-edit.jpg

@LisoUseInAIKyrios
Copy link
Contributor Author

LisoUseInAIKyrios commented Oct 12, 2025

The fist nature screenshot is correct, and that video screenshot won't be changed by this PR.

The second screenshot (red/black icon) should be changed by this PR to whatever in-app custom branding is in use. I'm not completely certain, but it looks like your device follows Google ASOP design and the "small icon" is shown in the notification and not the application icon like Samsung and other manufacturers show.

The third screenshot (white YT icon beside the clock) will be changed by this PR for all devices.

@MarcaDian
Copy link
Contributor

MarcaDian commented Oct 12, 2025

It's very strange why they haven't changed. These screenshots were with the latest changes to this PR. Need to recheck.

@LisoUseInAIKyrios
Copy link
Contributor Author

LisoUseInAIKyrios commented Oct 12, 2025

Do you have a custom icon set in the settings?

For me, new video notifications use the ReVanced status bar icon.

Maybe there's a different code path for some devices, or for different kinds of notifications (like the "background playback enabled" message).

@MarcaDian
Copy link
Contributor

MarcaDian commented Oct 12, 2025

It seems there was some mistake, now it is displayed.

But first of all, the color still needs to be white.

And the icon in the status bar seems to be of normal size, but it is different size from the manager icon.
Maybe this needs to be changed in the manager, but I understand that it won't happen soon, or it won't happen at all.

Screenshot_2025-10-12-20-01-05-764_app.revanced.manager.flutter-edit.jpg

Screenshot_2025-10-12-20-03-18-906_com.github.android-edit.jpg

IMG_20251012_200237.jpg

@LisoUseInAIKyrios
Copy link
Contributor Author

I think the red icon tint is added by YT, and the extension code can change that.

Should either change the size here to be the same as Manager, or change Manager to be the same size as here. Not sure which size is better.

Current PR:
Lawnchair

@MarcaDian
Copy link
Contributor

If compare the status bar icons in my vendor, the correct size is the one that is now.

It roughly corresponds to the height of the original quantum icon.

@LisoUseInAIKyrios
Copy link
Contributor Author

Need to update revanced_notification_icon_rounded.xml because the modified version I added isn't centered exactly correct.

Otherwise I think this just about ready. Will make another PR to add the permanent icon change patch option.

@MarcaDian
Copy link
Contributor

Make it the same height as the minimum/scaled?

@LisoUseInAIKyrios
Copy link
Contributor Author

LisoUseInAIKyrios commented Oct 12, 2025

Hmm, I think try using the full vertical space (Or 95% of the vertical space)?

If we use the height of the minimal V then it might look too small.

Some circle icons use the full vertical space (see the 'sleeping' status bar icon in screenshot above).

@MarcaDian
Copy link
Contributor

MarcaDian commented Oct 12, 2025

This is how it is showing to me now (current PR).

Screenshot_2025-10-12-20-21-10-947_com.miui.home-edit.jpg

We can't make the lines thicker because we're breaking branding rules?
Or maybe can make the circle a solid fill.

@LisoUseInAIKyrios
Copy link
Contributor Author

LisoUseInAIKyrios commented Oct 12, 2025

I think the V looks too small. The status bar icon is icon is very tiny to begin with.

Maybe we should use the same 'no-ring' status bar icon for all the preset branding types.

Edit: changed all built-in icon styles to use the same status bar icon (icon shown in the first post).

@LisoUseInAIKyrios
Copy link
Contributor Author

Please confirm if the notification icon tint is now correct.

@MarcaDian
Copy link
Contributor

MarcaDian commented Oct 12, 2025

I don't know how to check the notification icon in music, I don't use comments or subscribes and I've never received notifications here. Let's hope everything works.

The icon seems to have the correct scaling.
Screenshot_2025-10-12-22-07-29-164_app.revanced.android.apps.youtube.music-edit.jpg
I probably add the same one to the PR in manager, it still uses png.

PS: compose manager doesn't show a notification icon in the status bar?
PPS: maybe related to ReVanced/revanced-manager#2710

Screenshot_2025-10-12-22-14-01-629_app.revanced.manager.jpg

@LisoUseInAIKyrios
Copy link
Contributor Author

@MarcaDian Can you check the small icon now? I tried removing the tint and maybe now it'll automatically color it.

@LisoUseInAIKyrios LisoUseInAIKyrios force-pushed the fix/custom_branding_permanent_patch_option branch from a3ec48e to c141747 Compare October 13, 2025 06:36
@MarcaDian
Copy link
Contributor

Screenshot_2025-10-13-10-15-52-509_com.android.settings-edit.jpg

Screenshot_2025-10-13-10-15-37-010_com.android.settings-edit.jpg

@LisoUseInAIKyrios
Copy link
Contributor Author

Is that blue tint a theme color of your device? If so then that looks correct (and much better than the black/grey color of before).

@MarcaDian
Copy link
Contributor

Is it intentional that a different app name is used in notifications (and during installation)?

Screenshot_2025-10-13-10-27-20-760_com.miui.home-edit.jpg

Screenshot_2025-10-13-10-27-07-976_com.miui.home-edit.jpg

@MarcaDian
Copy link
Contributor

Is that blue tint a theme color of your device?

Yes, this is the accent color of the theme.

@LisoUseInAIKyrios
Copy link
Contributor Author

Notifications use the manifest application name (that name cannot be changed using an in-app setting).

The system YouTube app shows along side patched YouTube in some places such as:

  • 'Open with' prompt, that can show when searching in the launcher and picking a shortcut action (Shorts, search, subscriptions).
  • The system app list, where both patched YouTube and system YouTube appears (which app is which?)
  • The microG registered apps list (is it regular YouTube, or patched YouTube?)

Because the system YouTube app cannot be completely uninstalled, it makes patched YouTube appear identical to the original YouTube for the situations listed above.

To fix this ambiguity, I changed the manifest application name to "YouTube ReVanced" to reduce end user confusion.

The launcher still always shows whatever name the user has selected in the app settings.

@LisoUseInAIKyrios
Copy link
Contributor Author

I think this is ready. Will merge in a day or two.

@LisoUseInAIKyrios LisoUseInAIKyrios changed the title fix(YouTube - Custom branding): Use ReVanced icon for notification small icon fix(YouTube - Custom branding): Use ReVanced icon for small notification icon Oct 13, 2025
@LisoUseInAIKyrios LisoUseInAIKyrios changed the title fix(YouTube - Custom branding): Use ReVanced icon for small notification icon fix(YouTube - Custom branding): Use ReVanced icon for status bar notification icon Oct 13, 2025
@LisoUseInAIKyrios LisoUseInAIKyrios force-pushed the fix/custom_branding_permanent_patch_option branch from e31a698 to 9a5a59b Compare October 13, 2025 11:22
@LisoUseInAIKyrios LisoUseInAIKyrios merged commit 10ea250 into ReVanced:dev Oct 14, 2025
1 check passed
@LisoUseInAIKyrios LisoUseInAIKyrios deleted the fix/custom_branding_permanent_patch_option branch October 14, 2025 05:54
github-actions bot pushed a commit that referenced this pull request Oct 14, 2025
# [5.43.0-dev.2](v5.43.0-dev.1...v5.43.0-dev.2) (2025-10-14)

### Bug Fixes

* **YouTube - Custom branding:** Use ReVanced icon for status bar notification icon ([#6108](#6108)) ([10ea250](10ea250))
@MarcaDian
Copy link
Contributor

MarcaDian commented Oct 14, 2025

By the way, I just noticed in music ReVanced icon is white, unlike YouTube.

Screenshot_2025-10-14-09-48-28-468_app.revanced.android.apps.youtube.music-edit.jpg

Screenshot_2025-10-14-09-57-07-814_app.revanced.android.youtube-edit.jpg

@LisoUseInAIKyrios
Copy link
Contributor Author

What color is YouTube?

The most we can do is tint the small icon (YouTube code tints it red). If the small icon xml itself uses any color except white or black, then the system status bar shows those colors (very surprising that Android would allow that).

@MarcaDian
Copy link
Contributor

MarcaDian commented Oct 14, 2025

Black. Added a screenshot above.

@MarcaDian
Copy link
Contributor

I apologize. I just patched to this pre-release and the icon is black again. I must have installed a version where you inverted the colors.

So it turns out that Android uses colors from xml files.

Screenshot_2025-10-14-10-04-30-694_app.revanced.android.apps.youtube.music-edit.jpg

@LisoUseInAIKyrios
Copy link
Contributor Author

What color is the small icon if branding is set to original?

If YT shows a white icon, we can change the ReVanced XML to use white (status bar works the same if XML is either black or white)

@MarcaDian
Copy link
Contributor

MarcaDian commented Oct 14, 2025

If original

Screenshot_2025-10-14-10-08-36-706_app revanced android apps youtube music-edit

Screenshot_2025-10-14-10-09-59-686_app revanced android youtube-edit

@MarcaDian
Copy link
Contributor

I can try changing it myself and check, then I'll let you know if it works.

@LisoUseInAIKyrios
Copy link
Contributor Author

If changing the XML color to white works, then make a PR with the change. Can add a comment to the XML explaining the paths must be white

@MarcaDian
Copy link
Contributor

MarcaDian commented Oct 14, 2025

It seems to work.

Screenshot_2025-10-14-11-05-20-635_com.miui.home-edit.jpg

Screenshot_2025-10-14-11-13-45-555_com.android.settings-edit.jpg

Screenshot_2025-10-14-11-11-11-964_app.revanced.android.apps.youtube.music-edit.jpg

Screenshot_2025-10-14-11-05-11-149_com.miui.home-edit.jpg

Please add these changes directly, I don't have the opportunity to do it right now.

<?xml version="1.0" encoding="utf-8"?>
<!-- Copyright 2024 ReVanced. Not licensed under GPL. See https://github.com/ReVanced/revanced-branding -->
<vector xmlns:android="http://schemas.android.com/apk/res/android"
    android:width="24dp"
    android:height="24dp"
    android:viewportWidth="24"
    android:viewportHeight="24">

    <!-- The path is set to white (#FFFFFF) to ensure the icon appears white in the expanded status bar panel. -->
    <path
        android:fillColor="#FFFFFF"
        android:pathData="M4.03516,3 C3.80859,3,3.59375,3.11719,3.46875,3.30469 C3.34375,3.49609,3.32422,3.73828,3.41406,3.94922 C4.87109,7.27344,9.71875,18.3359,10.707,20.5938 C10.8164,20.8398,11.0586,21,11.3281,21 L12.6719,21 C12.9375,21,13.1836,20.8398,13.293,20.5938 C14.2813,18.3359,19.1289,7.27344,20.5859,3.94922 C20.6758,3.73828,20.6563,3.49609,20.5313,3.30469 C20.4063,3.11719,20.1914,3,19.9648,3 L19.0898,3 C18.8984,3,18.7227,3.11328,18.6445,3.28906 C17.875,5.04688,13.8008,14.3203,12.4414,17.418 C12.3672,17.5938,12.1914,17.707,12,17.707 C11.8086,17.707,11.6328,17.5938,11.5586,17.418 C10.1992,14.3203,6.125,5.04688,5.35547,3.28906 C5.27734,3.11328,5.10156,3,4.91016,3 Z M7.47266,3 C7.26563,3,7.07422,3.10938,6.97266,3.28906 C6.86719,3.46875,6.86719,3.69141,6.97266,3.87109 C8.02344,5.69141,10.4453,9.88672,11.4961,11.7109 C11.6016,11.8906,11.793,12,12,12 C12.207,12,12.3984,11.8906,12.5039,11.7109 C13.5547,9.88672,15.9766,5.69141,17.0273,3.87109 C17.1328,3.69141,17.1328,3.46875,17.0273,3.28906 C16.9258,3.10938,16.7344,3,16.5273,3 Z M7.47266,3" />
</vector>

@MarcaDian
Copy link
Contributor

MarcaDian commented Oct 14, 2025

It's interesting how Android colors a colored PNG notification icon to white/black color.
In the ReVanced manager, the notification icon is a PNG logo with a colored triangle. The same thing happens on YouTube.

github-actions bot pushed a commit that referenced this pull request Oct 14, 2025
# [5.43.0](v5.42.1...v5.43.0) (2025-10-14)

### Bug Fixes

* **Custom branding:** Use white notification icon for expanded status bar panel ([95eee59](95eee59))
* **Instagram - Change sharing domain:** Display patch option ([#6089](#6089)) ([be2b144](be2b144))
* **X / Twitter - Change Link Sharing Domain:** Change link domain of share copy action ([#6091](#6091)) ([5484625](5484625))
* **YouTube - Custom branding:** Do not add a broken custom icon if the user provides an invalid custom icon path ([6555f6e](6555f6e))
* **YouTube - Custom branding:** Use ReVanced icon for status bar notification icon ([#6108](#6108)) ([10ea250](10ea250))
* **YouTube - Force original audio:** Do not use translated audio if stream spoofing is off and force audio is on ([0c19dba](0c19dba))

### Features

* **Instagram:** Add `Hide suggested content` patch ([#6075](#6075)) ([50f0b9c](50f0b9c))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug(YouTube - Custom branding): Push notifications do not show branding icon

3 participants