fix(Strava): Fix Overwrite media upload parameters patch (alt)#6492
Draft
xehpuk wants to merge 1 commit intoReVanced:devfrom
Draft
fix(Strava): Fix Overwrite media upload parameters patch (alt)#6492xehpuk wants to merge 1 commit intoReVanced:devfrom
Overwrite media upload parameters patch (alt)#6492xehpuk wants to merge 1 commit intoReVanced:devfrom
Conversation
xehpuk
changed the title
Overwrite media upload parameters patchOverwrite media upload parameters patch (alt)
Member
|
Whats meant with "less invasive"? |
Contributor
Author
|
It's just a minimal change to
While the other PR needs at least Kotlin v2.2 for the context parameters. |
Contributor
Author
|
I guess the helper method is unnecessary. Could recreate the original method instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A "less invasive" alternative to #6491. Adds a helper method inside the patch.