Skip to content

Added username & userId to /user command #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 15, 2024
Merged

Added username & userId to /user command #244

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
fb6669a
added username & userId to /user command
PeeyushPrashant Sep 9, 2024
b114f99
corrected dummy user
PeeyushPrashant Sep 10, 2024
6a44bf8
corrected formatting
PeeyushPrashant Sep 11, 2024
8b40f37
user details format correction
PeeyushPrashant Sep 11, 2024
ffa0f3f
added feature flag
PeeyushPrashant Sep 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/utils/formatUserDetails.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@ export function formatUserDetails(userDetails: UserResponseType) {
const userFullName = `**Full Name :** ${userDetails.user?.first_name} ${userDetails.user?.last_name}`;
const discordJoinedAt = `**Joined Server on :** ${convertedTimestamp}`;
const userState = `**State :** ${userDetails.user?.state}`;
const userName = `**User Name :** ${userDetails.user?.username}`;
const userId = `**User Id :** ${userDetails.user?.id}`;

return `## User Details\n${userFullName}\n${discordJoinedAt}\n${userState}`;
return `## User Details\n${userFullName}\n${discordJoinedAt}\n${userState}\n${userName}\n${userId}`;
}
20 changes: 10 additions & 10 deletions tests/fixtures/user.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ export const user = {
incompleteUserDetails: false,
discordJoinedAt: "2023-08-08T11:40:42.522000+00:00",
discordId: "858838385330487336",
github_display_name: "Sunny Sahsi",
github_display_name: "John Doe",
updated_at: 1694888822719,
roles: {
archived: false,
Expand All @@ -12,10 +12,10 @@ export const user = {
super_user: false,
archive: false,
},
last_name: "Sahsi",
github_id: "sahsisunny",
first_name: "Sunny",
username: "sunny",
last_name: "Doe",
github_id: "johndoe",
first_name: "John",
username: "johndoe",
state: "ACTIVE",
};

Expand Down Expand Up @@ -179,7 +179,7 @@ export const userWithoutDiscordJoinedAt = {
incompleteUserDetails: false,
discordJoinedAt: "",
discordId: "504855562094247953",
github_display_name: "Jyotsna Mehta",
github_display_name: "John Doe",
updated_at: 1694888822719,
roles: {
archived: false,
Expand All @@ -188,10 +188,10 @@ export const userWithoutDiscordJoinedAt = {
super_user: false,
archive: false,
},
last_name: "Mehta",
github_id: "j24m",
first_name: "Jyotsna",
username: "jyotsna",
last_name: "Doe",
github_id: "johndoe",
first_name: "John",
username: "johndoe",
state: "IDLE",
};

Expand Down
13 changes: 9 additions & 4 deletions tests/unit/utils/formatUserDetails.test.ts
View file
Open in desktop
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT: Can you use dummy user data here

Copy link
Contributor Author

@PeeyushPrashant PeeyushPrashant Sep 10, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I did so because the userFullName and userState also had dummy values.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I mean change the username with a dummy value like john dow, or use Ankush data
as a user can remove from the RDS as Jyotsna is not on RDS

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay I have added dummy value now

Original file line number Diff line number Diff line change
Expand Up @@ -16,26 +16,31 @@ describe("formatUserDetails function", () => {
it("should format user details correctly", () => {
const formattedDetails = formatUserDetails(userResponse).trim();

const userFullName = `**Full Name :** Sunny Sahsi`;
const userFullName = `**Full Name :** John Doe`;
const discordJoinedAt = `**Joined Server on :** ${convertTimeStamp(
userResponse
)}`;
const userState = `**State :** ACTIVE`;
const userName = `**User Name :** johndoe`;
const userId = `**User Id :** iODXB6ns8jaZB9p0XlBw`;

const expectedFormattedDetails = `## User Details\n${userFullName}\n${discordJoinedAt}\n${userState}`;
const expectedFormattedDetails = `## User Details\n${userFullName}\n${discordJoinedAt}\n${userState}\n${userName}\n${userId}`;
expect(formattedDetails).toEqual(expectedFormattedDetails);
});

it("should return empty string if discordJoinedAt is undefined", () => {
const formattedDetails = formatUserDetails(
userWithoutDiscordJoinedAtResponse
).trim();
const userFullName = `**Full Name :** Jyotsna Mehta`;

const userFullName = `**Full Name :** John Doe`;
const discordJoinedAt = `**Joined Server on :** ${convertTimeStamp(
userWithoutDiscordJoinedAtResponse
)}`;
const userState = `**State :** IDLE`;
const expectedFormattedDetails = `## User Details\n${userFullName}\n${discordJoinedAt}\n${userState}`;
const userName = `**User Name :** johndoe`;
const userId = `**User Id :** DWcTUhbC5lRXfDjZRp06`;
const expectedFormattedDetails = `## User Details\n${userFullName}\n${discordJoinedAt}\n${userState}\n${userName}\n${userId}`;
expect(formattedDetails).toEqual(expectedFormattedDetails);
});
});
Loading