Added username & userId to /user command #244
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeeyushPrashant
changed the title
vinit717
reviewed
Sep 9, 2024
There was a problem hiding this comment.
NIT: Can you use dummy user data here
There was a problem hiding this comment.
Yes, I did so because the userFullName and userState also had dummy values.
There was a problem hiding this comment.
No, I mean change the username with a dummy value like john dow, or use Ankush data
as a user can remove from the RDS as Jyotsna is not on RDS
There was a problem hiding this comment.
Okay I have added dummy value now
vinit717
reviewed
Sep 10, 2024
tejaskh3
suggested changes
Sep 11, 2024
vinit717
previously approved these changes
Sep 11, 2024
iamitprakash
requested changes
Sep 11, 2024
iamitprakash
requested changes
Sep 11, 2024
iamitprakash
approved these changes
Sep 12, 2024
|
@PeeyushPrashant use Ankush's data |
vinit717
approved these changes
Sep 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Date: 09/09/24
Developer Name: Prashant Peeyush
Issue Ticket Number
Description
userId & userName will also be displayed along with other details when
/usercommand is run on discordDocumentation Updated?
Under Feature Flag
Database Changes
Breaking Changes
Development Tested?
Screenshots
Screenshot 1
screen-capture.4.webm
Test Coverage
Screenshot 1