Skip to content

Conversation

ravikumar1002
Copy link
Contributor

@ravikumar1002 ravikumar1002 commented Aug 3, 2023

Issue: #1345

Task: Real-Dev-Squad/website-www#538

What is the change?

Added github_created_at key: value for a new joiner in the user info

Database changes:

Yes but for new joiners, Updating existing users I will create a new ticket for that after getting merge this PR #1044

Test Result:

image
image

Demo *github_created_at key:

image

Copy link
Contributor

@sahsisunny sahsisunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is the test?

@ravikumar1002
Copy link
Contributor Author

Where is the test?

How to write test for this one line

@sahsisunny
Copy link
Contributor

Where is the test?

How to write test for this one line

Go to google.com and search "how to write test?"

sahsisunny
sahsisunny previously approved these changes Aug 7, 2023
Copy link
Contributor

@sahsisunny sahsisunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iamitprakash iamitprakash merged commit 267815b into Real-Dev-Squad:develop Aug 12, 2023
@ravikumar1002 ravikumar1002 mentioned this pull request Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants