Skip to content
This repository was archived by the owner on Dec 18, 2025. It is now read-only.

feat(RHINENG-22427): Remove routing from policies completely#601

Merged
adonispuente merged 2 commits intoRedHatInsights:masterfrom
adonispuente:policies
Dec 11, 2025
Merged

feat(RHINENG-22427): Remove routing from policies completely#601
adonispuente merged 2 commits intoRedHatInsights:masterfrom
adonispuente:policies

Conversation

@adonispuente
Copy link
Collaborator

@adonispuente adonispuente commented Dec 9, 2025

This removes policies routing completely.

Summary by Sourcery

Remove the frontend deployment configuration and its reference from the frontend configuration file.

Build:

  • Remove frontendCRDPath configuration from the frontend build config.

Deployment:

  • Delete the frontend Kubernetes deployment manifest and stop referencing it from the config.

@sourcery-ai
Copy link

sourcery-ai bot commented Dec 9, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Removes the legacy policies frontend routing configuration by dropping the frontendCRDPath setting from fec.config.js and deleting the now-unused deploy/frontend.yml manifest.

File-Level Changes

Change Details Files
Remove legacy frontend routing configuration from fec.config.js.
  • Delete the frontendCRDPath configuration property that pointed to the frontend deployment manifest.
  • Ensure the module export now only contains the valid configuration options without trailing commas.
fec.config.js
Delete the unused frontend deployment manifest associated with policies routing.
  • Remove deploy/frontend.yml from the repository, eliminating the legacy frontend deployment definition.
deploy/frontend.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.23%. Comparing base (d1e21a1) to head (ef47fd9).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #601   +/-   ##
=======================================
  Coverage   88.23%   88.23%           
=======================================
  Files         116      116           
  Lines        2507     2507           
  Branches      496      496           
=======================================
  Hits         2212     2212           
- Misses        280      290   +10     
+ Partials       15        5   -10     

see 7 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@adonispuente adonispuente marked this pull request as ready for review December 11, 2025 14:38
@adonispuente adonispuente requested a review from a team as a code owner December 11, 2025 14:38
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@adonispuente adonispuente merged commit d745527 into RedHatInsights:master Dec 11, 2025
2 of 6 checks passed
adonispuente added a commit to adonispuente/policies-ui-frontend that referenced this pull request Dec 12, 2025
adonispuente added a commit to adonispuente/policies-ui-frontend that referenced this pull request Dec 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants