fix: re-index state array after block deletion to prevent undefined k…#21
Merged
GigaGiorgadze merged 4 commits intomainfrom Mar 2, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🐛 Fix: Crash when deleting blocks sequentially
Closes #15
Problem
Deleting the first block then trying to delete any remaining block threw:
After
unset($items[0]), PHP keeps the original keys — so the array goes from[0, 1, 2]to[1, 2]. The blade template always passes$loop->index(0-based) as theindexargument. On the next delete, it sendsindex = 0, but key0no longer exists in the state array.Fix
Use
array_values()after unsetting to reset keys back to0, 1, 2...Test
Added a regression test that creates 2 blocks, deletes the first, then deletes the second — covering the exact scenario that was broken.