fix: resolve problem with severity change for configurable rules #1811
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ba53b37 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Contributor
Coverage report
Show files with reduced coverage 🔻
Test suite run success814 tests passing in 121 suites. Report generated by 🧪jest coverage report action from ba53b37 |
JLekawa
reviewed
Nov 25, 2024
JLekawa
approved these changes
Nov 25, 2024
tatomyr
reviewed
Nov 25, 2024
packages/core/src/utils.ts
Outdated
| if (!obj) return; | ||
| for (const k of Object.keys(obj)) { | ||
| if (!target.hasOwnProperty(k)) continue; | ||
| if (typeof target[k] === 'object' && target[k] !== null && typeof obj[k] === 'string') { |
Collaborator
There was a problem hiding this comment.
Please use isPlainObject.
JLekawa
approved these changes
Nov 25, 2024
JLekawa
reviewed
Nov 25, 2024
This was referenced Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What/Why/How?
Severity of configurable rules could not be overridden without full rule copy:
base.yaml
redocly.yaml
The above did not work.
Reference
Reported by a customer.
Related to https://github.com/Redocly/redocly/issues/12111
Testing
Covered with unit test.
Screenshots (optional)
Check yourself
Security