Merge 2.0.0 into main, closes #335 #1238

Rel1cx · 2025-09-24T21:20:08Z

What kind of change does this PR introduce?

Does this PR introduce a breaking change?

Yes, and the changes were approved in issue [Roadmap] Milestone 2.0 #335
No

Checklist

When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
I have added a convincing reason for adding this feature, if necessary

Other information

v2.0.0 (TBD)

💥 Breaking Changes

Target Environment Updates: Now ESM and ESLint Flat Config Only

Drop support for CommonJS (CJS) module format, packages are now distributed only as ECMAScript Modules (ESM)
Drop support for ESLint legacy config system, packages now support only ESLint Flat Config (eslint.config.js)
Drop support for Node.js 16 and 18, minimum required version is now Node.js 20
Drop support for ESLint 8, minimum required version is now ESLint 9.3.6
Drop support for TypeScript 4, minimum required version is now TypeScript 5.9.2

Removed Rules

Rule	Replaced by	Reason
react-x/avoid-shorthand-boolean	`react-x/jsx-shorthand-boolean`	consolidated
react-x/avoid-shorthand-fragment	`react-x/jsx-shorthand-fragment`	consolidated
react-x/ensure-forward-ref-using-ref	`react-x/no-useless-forward-ref`	renamed
react-x/jsx-no-duplicate-props	`react-x/jsx-no-duplicate-props`	renamed
react-x/no-comment-textnodes	`react-x/jsx-no-comment-textnodes`	renamed
react-x/no-complicated-conditional-rendering		discontinued
react-x/no-nested-components	`react-x/no-nested-component-definitions`	renamed
react-x/prefer-react-namespace-import	`react-x/prefer-namespace-import`	renamed
react-x/prefer-shorthand-boolean	`react-x/jsx-shorthand-boolean`	consolidated
react-x/prefer-shorthand-fragment	`react-x/jsx-shorthand-fragment`	consolidated
react-x/use-jsx-vars	`react-x/jsx-uses-vars`	renamed
react-dom/no-children-in-void-dom-elements	`react-dom/no-void-elements-with-children`	renamed
react-hooks-extra/no-direct-set-state-in-use-layout-effect	`react-hooks-extra/no-direct-set-state-in-use-effect`	consolidated
react-hooks-extra/no-unnecessary-use-callback	`react-x/no-unnecessary-use-callback`	relocated
react-hooks-extra/no-unnecessary-use-memo	`react-x/no-unnecessary-use-memo`	relocated
react-hooks-extra/no-unnecessary-use-prefix	`react-x/no-unnecessary-use-prefix`	relocated
react-hooks-extra/prefer-use-state-lazy-initialization	`react-x/prefer-use-state-lazy-initialization`	relocated

Removed Presets

Preset	Replaced by	Reason
`core`	`x`	renamed
`core-legacy`		discontinued
`off-dom`	`disable-dom`	renamed
`off-dom-legacy`		discontinued
`x-legacy`		discontinued
`dom-legacy`		discontinued
`web-api-legacy`		discontinued
`recommended-legacy`		discontinued
`recommended-typescript-legacy`		discontinued
`recommended-type-checked-legacy`		discontinued

Removed Settings

Setting	Replaced by	Reason
`additionalComponents`		discontinued
`additionalHooks`		discontinued
`skipImportCheck`		discontinued

The rule implementations have been refactored to improve performance and maintainability.

✨ New

Added the following new rules:

react-x/jsx-shorthand-boolean: Enforces a consistent style for boolean attributes
react-x/jsx-shorthand-fragment: Enforces a consistent style for React Fragments
react-x/no-forbidden-props: Disallows specific props on components
react-x/no-unnecessary-key: Reports unnecessary key props on elements
react-x/no-unused-props: Reports unused props in components
react-dom/no-string-style-prop: Disallows string values for the style prop
react-dom/prefer-namespace-import: Enforces using a namespace import for react-dom

Added the following new rule to the recommended-type-checked preset:

react-x/no-unused-props: Reports unused props in components

The following rules now support Codemod features:

react-x/no-component-did-update
react-x/no-component-will-receive-props
react-x/no-component-will-update
react-x/no-context-provider
react-x/no-forward-ref
react-x/no-string-refs

The following rules now support auto-fix:

react-x/prefer-namespace-import
react-dom/prefer-namespace-import

The following rules now support suggestion fixes:

react-dom/no-missing-button-type
react-dom/no-missing-iframe-sandbox
react-dom/no-unsafe-target-blank

New configuration preset added:

disable-conflict-eslint-plugin-react: Disable rules in eslint-plugin-react that conflict with rules in our plugins

🐞 Fixes

fix(react-x/no-unnecessary-use-prefix): fix false positive of React Hooks defined within the callback function of vi.mock(...) in Vitest test files
fix(react-web-api/no-leaked-event-listener): fix useEffect setup function check to handle React.useEffect() calls correctly
fix(react-naming-convention/filename): fix false positive on well-known filenames like 404.tsx, _app.tsx, [slug].tsx

🪄 Improvements

refactor: simplify React APIs detection logic
refactor: cleanup utilities and simplify rule implementations
docs: add comparison table between eslint-plugin-react and eslint-react rules
docs: replace tseslint.config with defineConfig in all examples
build: migrate build system from tsup to tsdown for better performance

Full Changelog: v1.53.1...v2.0.0

…closes #1161 (#1178)

…d improve validation (#1185) Signed-off-by: REL1CX <[email protected]> Co-authored-by: Copilot <[email protected]>

vercel · 2025-09-24T21:20:13Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Comments	Updated (UTC)
eslint-react	Ready	Preview	Comment	Sep 25, 2025 10:10pm

Copilot

Pull Request Overview

This pull request merges version 2.0.0 into main, representing a major version bump with significant breaking changes and new features. The update introduces ESM-only distribution, updates minimum system requirements, and consolidates multiple rule changes.

Key changes include:

Migrated to ESM-only packages with updated Node.js (20.19.0), ESLint (9.36.0), and TypeScript (5.9.2) requirements
Added new rules and consolidated existing ones with improved functionality
Removed legacy CommonJS support and updated build tooling from tsup to tsdown

Reviewed Changes

Copilot reviewed 224 out of 717 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
packages/plugins/eslint-plugin-react-dom/src/rules/no-string-style-prop.spec.ts	New test file for rule that disallows string values for style prop
packages/plugins/eslint-plugin-react-dom/src/rules/no-string-style-prop.mdx	Documentation for new no-string-style-prop rule
packages/plugins/eslint-plugin-react-dom/src/rules/no-script-url.ts	Refactored to use new kit utilities and updated imports
packages/plugins/eslint-plugin-react-dom/src/rules/no-missing-iframe-sandbox.ts	Enhanced with suggestion fixes and improved error handling
packages/plugins/eslint-plugin-react-dom/src/rules/no-missing-button-type.ts	Added suggestion fixes for button type attribute
packages/plugins/eslint-plugin-react-dom/src/plugin.ts	Updated plugin structure and removed deprecated rules
packages/plugins/eslint-plugin-react-dom/package.json	Updated to ESM-only with version bump and dependency updates
packages/core/src/jsx/jsx-config.ts	Consolidated JSX configuration utilities with improved documentation
packages/core/src/jsx/jsx-attribute-value.ts	Complete rewrite of attribute value resolution system
package.json	Version bump and updated tooling dependencies

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

packages/plugins/eslint-plugin-react-dom/src/rules/no-missing-iframe-sandbox.ts

packages/plugins/eslint-plugin-react-dom/src/rules/no-missing-button-type.ts

packages/core/src/jsx/jsx-attribute-value.ts

packages/core/src/jsx/jsx-detection.ts

socket-security · 2025-09-25T21:29:34Z

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Package	Supply Chain Security	Quality	Maintenance
fumadocs-docgen@3.0.0 ⏵ 3.0.1	⁺³	⁺³	⁺¹
@typescript-eslint/parser@8.44.0 ⏵ 8.44.1
fumadocs-typescript@4.0.8 ⏵ 4.0.9	⁺⁴	⁺³	⁺²
@effect-atom/atom-react@0.2.0
@radix-ui/react-toast@1.2.15
fumadocs-mdx@12.0.0 ⏵ 12.0.1		⁺¹	⁺¹
fumadocs-core@15.7.13 ⏵ 15.8.0	⁺¹	⁺¹	⁺¹
@typescript-eslint/rule-tester@8.44.0 ⏵ 8.44.1			⁺¹
@typescript-eslint/type-utils@8.44.0 ⏵ 8.44.1
@typescript-eslint/types@8.44.0 ⏵ 8.44.1
@typescript-eslint/utils@8.44.0 ⏵ 8.44.1
@typescript-eslint/scope-manager@8.44.0 ⏵ 8.44.1
@typescript-eslint/typescript-estree@8.44.0 ⏵ 8.44.1	⁺¹	⁺¹
eslint-plugin-fast-import@1.4.3 ⏵ 1.4.4	⁺²	⁺¹	⁺¹
next@15.5.3 ⏵ 15.5.4	⁺¹	⁺¹
@radix-ui/react-icons@1.3.2
jiti@2.5.1 ⏵ 2.6.0	⁺¹
eslint-plugin-jsdoc@60.0.0 ⏵ 60.3.1	^-1		^-4
@eslint/markdown@7.2.0 ⏵ 7.3.0	⁺²		⁺¹⁰
@tsconfig/strictest@2.0.5 ⏵ 2.0.6		⁺²⁵	⁺²²
@effect/platform@0.90.10 ⏵ 0.91.1	⁺¹	⁺¹	⁺³
@next/eslint-plugin-next@15.5.3 ⏵ 15.5.4	⁺¹	⁺²⁸	⁺²
@effect/platform-node@0.96.1 ⏵ 0.97.1	⁺¹	⁺²⁵	⁺⁵
fumadocs-ui@15.7.13 ⏵ 15.8.0	⁺²	⁺²⁵	⁺⁵
@effect/language-service@0.40.0 ⏵ 0.41.0	⁺¹	⁺¹	⁺³
eslint-plugin-react-refresh@0.4.20 ⏵ 0.4.22	⁺¹	⁺¹	⁺¹²

View full report

Copilot

Pull Request Overview

Copilot reviewed 297 out of 492 changed files in this pull request and generated 6 comments.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

packages/plugins/eslint-plugin-react-x/src/rules/no-unused-props.ts

packages/plugins/eslint-plugin-react-x/src/rules/jsx-shorthand-boolean.ts

packages/plugins/eslint-plugin-react-x/src/rules/no-forbidden-props.ts

packages/plugins/eslint-plugin-react-hooks-extra/src/rules/no-direct-set-state-in-use-effect.ts

Copilot

Pull Request Overview

Copilot reviewed 297 out of 493 changed files in this pull request and generated 2 comments.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

packages/plugins/eslint-plugin-react-x/src/rules/no-unused-props.spec.ts

packages/plugins/eslint-plugin-react-hooks-extra/package.json

Co-authored-by: Copilot <[email protected]> Signed-off-by: REL1CX <[email protected]>

Rel1cx and others added 30 commits August 17, 2025 20:20

style: use dprint for imports and exports sorting

beb2525

chore: minor fixes

abbaa90

chore(website): enable '@eslint-react/no-unused-props' rule

df52cd5

chore(website): minor fixes

f08fdf8

release: 2.0.0-beta.33

e53fec2

Merge branch 'main' into 2.0.0-beta

68a8775

chore: update lucide-react to version 0.540.0

2dddf88

feat: add no-unused-props rule to recommended-type-checked preset, …

717fe4c

…closes #1161 (#1178)

release: 2.0.0-beta.34

09cca7b

docs: improve examples in react-x/no-unused-props (#1179)

4c0f56d

chore: remove ununsed files

f6f0f89

chore: update deps

5c2ef9b

chore: update deps

831529e

chore: remove ununsed code

65a33e3

chore: update contributing docs

c038699

feat: add vitest mock env detection, closes #1181 (#1182)

0780100

release: 2.0.0-beta.35

29eff3f

chore: update deps

79256e1

refactor: move context detection utilities to kit package (#1183)

4cff122

release: 2.0.0-beta.36

6a816cf

ci: update branches in publish workflow

d2284e4

release: 2.0.0-beta.37

b5f5f69

release: 2.0.0-next.137

6a67592

fix: improve hook detection logic and vi.mock utilities (#1184)

aac93d0

release: 2.0.0-next.138

6369062

release: 2.0.0-beta.38

9bd6a60

chore: update dprint plugins

cd5befe

feat(naming-convention/filename): enhance default excepts patterns an…

e352f62

…d improve validation (#1185) Signed-off-by: REL1CX <[email protected]> Co-authored-by: Copilot <[email protected]>

release: 2.0.0-beta.39

bd874c0

release: 2.0.0-next.139

57cf17a

docs: update roadmap

bc58369

Rel1cx requested a review from Copilot September 24, 2025 21:21

Copilot AI reviewed Sep 24, 2025

View reviewed changes

chore: update deps

9e6d1f6

vercel bot deployed to Preview September 25, 2025 15:25 View deployment

vercel bot deployed to Preview September 25, 2025 21:11 View deployment

Rel1cx force-pushed the 2.0.0 branch from 0a2b44f to c836066 Compare September 25, 2025 21:16

docs: update changelog and add removed rules documentation

42c73c4

Rel1cx force-pushed the 2.0.0 branch from c836066 to 42c73c4 Compare September 25, 2025 21:19

Rel1cx added 2 commits September 26, 2025 05:21

release: 2.0.0-next.193

4088052

release: 2.0.0-beta.193

21c7670

vercel bot deployed to Preview September 25, 2025 21:25 View deployment

release: 2.0.0-beta.193

8e8160c

Rel1cx requested a review from Copilot September 25, 2025 21:31

vercel bot deployed to Preview September 25, 2025 21:31 View deployment

Copilot AI reviewed Sep 25, 2025

View reviewed changes

chore: cleanup

64823ca

Rel1cx requested a review from Copilot September 25, 2025 21:54

Copilot AI reviewed Sep 25, 2025

View reviewed changes

packages/plugins/eslint-plugin-react-x/src/rules/no-unused-props.spec.ts Show resolved Hide resolved

packages/plugins/eslint-plugin-react-hooks-extra/package.json Outdated Show resolved Hide resolved

Update packages/plugins/eslint-plugin-react-hooks-extra/package.json

5a8c513

Co-authored-by: Copilot <[email protected]> Signed-off-by: REL1CX <[email protected]>

Rel1cx marked this pull request as ready for review September 25, 2025 21:55

vercel bot deployed to Preview September 25, 2025 21:59 View deployment

Rel1cx added 2 commits September 26, 2025 06:04

release: 2.0.0-next.194

865444e

release: 2.0.0-beta.194

52152a2

vercel bot deployed to Preview September 25, 2025 22:10 View deployment

Rel1cx merged commit 53e7266 into main Sep 25, 2025
19 checks passed

Rel1cx deleted the 2.0.0 branch September 25, 2025 22:51

jkbdk mentioned this pull request Oct 20, 2025

[bug] @eslint-react/jsx-key-before-spread missing from all presets except all #1290

Closed

Uh oh!

Merge 2.0.0 into main, closes #335 #1238

Merge 2.0.0 into main, closes #335 #1238

Uh oh!

Conversation

Rel1cx commented Sep 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What kind of change does this PR introduce?

Does this PR introduce a breaking change?

Checklist

Other information

v2.0.0 (TBD)

💥 Breaking Changes

✨ New

🐞 Fixes

🪄 Improvements

Uh oh!

vercel bot commented Sep 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

socket-security bot commented Sep 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Rel1cx commented Sep 24, 2025 •

edited

Loading

vercel bot commented Sep 24, 2025 •

edited

Loading

socket-security bot commented Sep 25, 2025 •

edited

Loading