Merge 2.0.0 into main, closes #335

.github/CONTRIBUTING.md

@@ -1,26 +1,86 @@
 # ESLint React Contributing Guide
 
-Thank you for your interest in contributing to ESLint React! This guide will help you understand how to contribute effectively.
+Welcome to contributing to ESLint React! This guide will help you contribute effectively.
 
 > [!NOTE]
 > ESLint React is not a fork of or derived from `eslint-plugin-react`. Features in `eslint-plugin-react` may not appear in ESLint React.
 
-## Issue Reporting Guidelines
+## Issue Reporting Guide
 
-- **Search First** - Your issue may already be addressed
-- **Verify Version** - Confirm reproducibility with the latest stable release
-- **Clear Reproduction Steps Required** - Detailed steps to reproduce are essential
-- **Minimal Code Example** - Provide only the code necessary to demonstrate the issue
-- **Be Patient** - The team balances many responsibilities
+- **Search first**: Your issue may have already been reported.
+- **Verify version**: Ensure the issue is reproducible in the latest stable version.
+- **Provide clear reproduction steps**.
+- **Provide a minimal reproducible code example**.
 
-## Pull Request Guidelines
+## Pull Request Guide
 
-- **Sign Your Commits** - Ensure your commits are signed
-- **Multiple Small Commits Allowed** - GitHub will squash before merging
-- **New Features** - Provide strong rationale, preferably with prior discussion
-- **Bug Fixes** - Include `(fix: #xxxx)` in your PR title and detailed description
-- **Documentation Changes** - Include `(docs: #xxxx)` in your PR title and detailed description
+- **Sign your commits**.
+- **Small commits are welcome**: We will squash them before merging.
+- **New features**: Please provide a good reason, preferably by discussing it in an Issue first.
+- **Bug fixes**: Include `(fix: #xxxx)` in the PR title.
+- **Documentation changes**: Include `(docs: #xxxx)` in the PR title.
 
-## References
+## Development Commands
 
-- [Monorepo Structure](https://eslint-react.xyz/docs/contributing#monorepo-structure)
+### Build
+
+```bash
+# Build packages that are needed for development and publishing
+pnpm run build
+
+# Build packages that are used in the monorepo (e.g., plugins, configs)
+pnpm run build:pkgs
+
+# Build docs for all packages
+pnpm run build:docs
+
+# Build the website
+pnpm run build:website
+```
+
+### Testing
+
+```bash
+# Run all tests
+pnpm run test
+
+# Run a single test file
+pnpm vitest packages/plugins/eslint-plugin-react-x/src/rules/[rule-name].spec.ts
+```
+
+### Code Linting and Formatting
+
+```bash
+# Format the code
+pnpm run format:write
+
+# Run all checks
+pnpm run lint
+```
+
+## Development Workflow
+
+### Testing
+
+- Test files coexist with source files: `src/rules/[rule-name].spec.ts`.
+- Uses `TypeScript ESLint Rule Tester`.
+- Provides separate test setups for type-aware and non-type-aware rules.
+- Test fixtures support multiple TypeScript configurations (e.g., JSX variants).
+- Test helpers are located in the `test/` directory.
+
+### Developing a New Rule
+
+1. If there isn't a related Issue, create one first to discuss the new rule.
+2. Implement the rule in the plugin's `src/rules/` directory.
+3. Create the corresponding test file.
+4. Export the rule in the plugin's entry file (`src/plugin.ts`).
+5. Add documentation for the rule.
+6. If the rule should be enabled by default, update the preset configurations.
+7. Update the unified plugin to include the new rule.
+8. Update the website documentation.
+9. Run build and test commands.
+10. Submit a PR with a clear description of the changes.
+
+## Reference
+
+- [Monorepo Structure](https://beta.eslint-react.xyz/docs/contributing#monorepo-structure)

.github/ISSUE_TEMPLATE/feature_request.yml

@@ -4,32 +4,66 @@ description: Suggest an idea
 labels: ["feature request"]
 
 body:
+  - type: markdown
+    attributes:
+      value: |
+        ## Feature Request
+
+        Thank you for suggesting a new feature! Before submitting, please ensure your request meets our contribution guidelines.
   - type: textarea
     id: problem
     attributes:
-      label: Describe the problem
-      description: A clear description of the problem this feature would solve
-      placeholder: "I'm always frustrated when..."
+      label: Problem Description
+      description: Please describe the problem this feature will solve. Provide specific examples to illustrate the issue.
+      placeholder: "This feature will solve..."
     validations:
       required: true
 
   - type: textarea
-    id: solution
+    id: alternative-solutions
     attributes:
-      label: "Describe the solution you'd like"
-      description: A clear description of what change you would like
-      placeholder: "I would like to..."
+      label: Alternative Solutions
+      description: Have you tried to solve the problem by other means? Why aren't these methods sufficient to solve the problem?
+      placeholder: "I've tried..."
     validations:
-      required: false
+      required: true
 
   - type: textarea
-    id: alternatives
+    id: feature-details
     attributes:
-      label: Alternatives considered
-      description: "Any alternative solutions you've considered"
+      label: Feature Details
+      description: Suggest a name for the feature, as well as details about how it should work and any relevant use cases.
+      placeholder: |
+        Feature name: [FeatureName]
+
+        Details: Provide more background information and suggested implementation details
+    validations:
+      required: true
 
   - type: textarea
-    id: context
+    id: examples
+    attributes:
+      label: Examples
+      description: Provide examples of how this feature would be used in practice.
+      placeholder: |
+        Example usage:
+        ```tsx
+        // Example code demonstrating the feature
+        ```
+    validations:
+      required: true
+
+  - type: checkboxes
+    id: checklist
     attributes:
-      label: Additional context
-      description: Add any other context about the problem here.
+      label: Evaluation Checklist
+      description: Please check the following items to ensure the feature suggestion is reasonable
+      options:
+        - label: I have had problems that this feature would solve
+          required: true
+        - label: I could not find a way to solve the problem with existing features or workarounds
+          required: true
+        - label: I have thought very hard about potential edge cases and downsides, and they are acceptable
+          required: true
+        - label: I think the feature is well-defined and would provide clear value to users
+          required: true

.github/ISSUE_TEMPLATE/rule_request.yml

@@ -0,0 +1,86 @@
+name: 💬 Rule Request
+title: "[rule] "
+description: Suggest a rule
+labels: ["rule request"]
+
+body:
+  - type: markdown
+    attributes:
+      value: |
+        ## Rule Request
+
+        Thank you for suggesting a new rule! Before submitting, please ensure your request meets our rule writing standards.
+
+        ## References on Rule Design
+        - [What makes a good rule](https://package.elm-lang.org/packages/jfmengels/elm-review/latest/Review-Rule#what-makes-a-good-rule)
+        - [When to write or enable a rule](https://package.elm-lang.org/packages/jfmengels/elm-review/latest#when-to-write-or-enable-a-rule)
+
+  - type: textarea
+    id: problem
+    attributes:
+      label: Problem Description
+      description: Please describe what problem this rule will solve. Provide specific code examples to illustrate the issue.
+      placeholder: "This rule will solve..."
+    validations:
+      required: true
+
+  - type: textarea
+    id: alternative-solutions
+    attributes:
+      label: Alternative Solutions
+      description: Have you tried to solve the problem by changing the API or introducing a new API? Why aren't these methods sufficient to solve the problem?
+      placeholder: "I've tried..."
+    validations:
+      required: true
+
+  - type: textarea
+    id: rule-name-and-message
+    attributes:
+      label: Rule Name and Error Message
+      description: |
+        Suggest a name for the rule, as well as the error message and details that should be displayed when the rule is violated.
+
+        > A lint rule is an automated communication tool which sends messages to developers who have written patterns your rule wishes to prevent. As all communication, the message is important.
+      placeholder: |
+        Rule name: [PluginName]/[YourRuleName]
+
+        Error message: Briefly and clearly describe the problem
+
+        Details: Provide more background information and suggested solutions
+    validations:
+      required: true
+
+  - type: textarea
+    id: examples
+    attributes:
+      label: Examples
+      description: Provide code examples that should be flagged and code examples that should not be flagged.
+      placeholder: |
+        Code that should be flagged:
+        ```tsx
+        // Problematic code
+        ```
+
+        Code that should not be flagged:
+        ```tsx
+        // Correct code
+        ```
+    validations:
+      required: true
+
+  - type: checkboxes
+    id: checklist
+    attributes:
+      label: Evaluation Checklist
+      description: Please check the following items to ensure the rule suggestion is reasonable
+      options:
+        - label: I have had problems with the pattern I want to forbid
+          required: true
+        - label: I could not find a way to solve the problem by changing the API of the problematic code or introducing a new API
+          required: true
+        - label: I have thought very hard about what the corner cases could be and what kind of patterns this would forbid that are actually okay, and they are acceptable
+          required: true
+        - label: I think the rule explains well enough how to solve the issue, to make sure beginners are not blocked by it
+          required: true
+        - label: I have discussed this rule with team members, and they all find it valuable
+          required: false

.github/workflows/check-provenance.yml

@@ -0,0 +1,30 @@
+name: Check Provenance
+on:
+  push:
+    branches:
+      - main
+      - "2.0.0"
+  pull_request:
+    types: [opened, edited, reopened, synchronize]
+    branches:
+      - main
+      - "2.0.0"
+permissions:
+  contents: read
+jobs:
+  check-provenance:
+    runs-on: ubuntu-24.04-arm
+    steps:
+      - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
+        with:
+          fetch-depth: 0
+      - name: Check provenance downgrades
+        uses: danielroe/provenance-action@main
+        id: check
+        with:
+          fail-on-provenance-change: true # optional, default: false
+          lockfile: pnpm-lock.yaml # optional
+          #   base-ref: origin/main         # optional, default: origin/main
+          fail-on-downgrade: true # optional, default: true
+      - name: Print result
+        run: "echo 'Downgraded: ${{ steps.check.outputs.downgraded }}'"

.github/workflows/check.yml

@@ -2,7 +2,7 @@ name: Check
 on:
   push:
     branches:
-      - main
+      - "**"
   pull_request:
     types: [opened, edited, reopened, synchronize]
     branches:
@@ -13,13 +13,14 @@ jobs:
   check:
     runs-on: ubuntu-24.04-arm
     steps:
-      - uses: actions/checkout@v4
-      - name: Setup node@23
-        uses: actions/setup-node@v4
+      - name: Setup node@24
+        uses: actions/setup-node@a0853c24544627f65ddf259abe73b1d18a591444 # v5.0.0
         with:
-          node-version: 23
-      - name: Enable Corepack
-        run: corepack enable
+          node-version: 24
+      - name: Install pnpm
+        run: npm install -g pnpm
+      - name: Checkout repository
+        uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
       - name: Install front-end dependencies
         run: pnpm install
       - name: Build front-end assets

.github/workflows/publish.yml

@@ -3,7 +3,7 @@ on:
   push:
     branches:
       - main
-      - "2.0.0-next"
+      - "2.0.0"
     tags-ignore:
       - "**"
     paths-ignore:
@@ -21,14 +21,15 @@ jobs:
       contents: read
       id-token: write
     steps:
-      - uses: actions/checkout@v4
-      - name: Setup node@23
-        uses: actions/setup-node@v4
+      - name: Setup node@24
+        uses: actions/setup-node@a0853c24544627f65ddf259abe73b1d18a591444 # v5.0.0
         with:
-          node-version: 23
+          node-version: 24
           registry-url: "https://registry.npmjs.org"
-      - name: Enable Corepack
-        run: corepack enable
+      - name: Install pnpm
+        run: npm install -g pnpm
+      - name: Checkout repository
+        uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
       - name: Install dependencies
         run: pnpm install
       - name: Build front-end assets