Fix false positive for dom/no-missing-button-type when specifying non-trivial expression as value of type attribute, closes #1247

[Rel1cx]

What kind of change does this PR introduce?

• Bugfix
• Feature
• Docs
• Test
• New Binding issue #___
• Code style update
• Refactor
• Build-related changes
• Other, please describe:

Does this PR introduce a breaking change?

• Yes, and the changes were approved in issue #___
• No

Checklist

• When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
• I have added a convincing reason for adding this feature, if necessary

Other information

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Comments	Updated (UTC)
eslint-react	Building	Preview	Comment	Sep 30, 2025 4:13am

[socket-security]

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	@​typescript-eslint/​rule-tester@​8.44.1 ⏵ 8.45.0
	@​typescript-eslint/​utils@​8.44.1 ⏵ 8.45.0	+1		+1
	@​types/​node@​24.5.2 ⏵ 24.6.0	+1		+1
	eslint-plugin-de-morgan@​1.3.1 ⏵ 2.0.0	+1
	@​effect/​language-service@​0.41.0 ⏵ 0.41.1
	@​typescript-eslint/​parser@​8.44.1 ⏵ 8.45.0	+1		+30	+4
	@​typescript-eslint/​scope-manager@​8.44.1 ⏵ 8.45.0	+1		+23	+4
	@​typescript-eslint/​types@​8.44.1 ⏵ 8.45.0	+1		+25	+4
	@​typescript-eslint/​typescript-estree@​8.44.1 ⏵ 8.45.0	+2		+23	+4
	@​typescript-eslint/​type-utils@​8.44.1 ⏵ 8.45.0	+1		+25	+4
	@​effect/​platform-node@​0.97.1 ⏵ 0.98.0	+1		+25	+3
	@​effect/​platform@​0.91.1 ⏵ 0.92.0	+1		+1	+3
	effect@​3.17.14 ⏵ 3.18.0	+1		+10	+4
	@​effect-atom/​atom-react@​0.2.0 ⏵ 0.3.0	+11		+29	+7

View full report

[Copilot]

Pull Request Overview

This PR fixes a false positive in the dom/no-missing-button-type rule when non-trivial expressions are used as the value of the type attribute. The rule previously reported errors for dynamic type values like variables or expressions, even when they were valid.

• Simplified the rule logic to only check for the presence of a type attribute
• Removed complex static value resolution that was causing false positives
• Added comprehensive test cases for dynamic type attribute scenarios

Reviewed Changes

Copilot reviewed 21 out of 22 changed files in this pull request and generated no comments.

File	Description
packages/plugins/eslint-plugin-react-dom/src/rules/no-missing-button-type.ts	Simplified rule implementation by removing static value resolution
packages/plugins/eslint-plugin-react-dom/src/rules/no-missing-button-type.spec.ts	Updated tests by removing invalid test case and adding valid dynamic type scenarios
Multiple package.json files	Updated TypeScript ESLint dependencies from 8.44.1 to 8.45.0

Files not reviewed (1)

• pnpm-lock.yaml: Language not supported

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}