Skip to content

Conversation

yarikoptic
Copy link
Member

@yarikoptic yarikoptic commented Oct 10, 2025

Tasks:

Closes #188
Closes #189

TODO: needs to be merged with all the prior --run s into a single one
@yarikoptic yarikoptic requested a review from vmdocua October 10, 2025 13:38
@gemini-code-assist
Copy link

Summary of Changes

Hello @yarikoptic, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a crucial step in the container build process to explicitly manage file permissions within the /opt directory. By adding a chmod command, it ensures that all users within the generated container have appropriate read and execute access to the software and resources located under /opt, thereby preventing potential permission-related issues and enhancing the container's overall usability.

Highlights

  • Permissions for /opt: A new --run command has been added to the container generation script to recursively set read and execute permissions (a+rX) for the /opt directory.
  • Container Build Process: The permission setting is now an explicit step within the generate_container.sh script, ensuring that /opt and its contents have consistent access rights upon container creation.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a chmod command to set permissions for the /opt directory within the generated container. My review focuses on improving the implementation. I've identified a bug where shell variables were not being expanded correctly due to improper quoting. My suggestion fixes this bug and also merges the new chmod command with the preceding one, which aligns with your TODO in the description to consolidate --run commands. This will make the Dockerfile generation more efficient by reducing layers.

Comment on lines 98 to 99
--run "bash -c '$REPROSTIM_CAPTURE_CLEAN'" \
--run "chmod a+rX -R /opt"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

There's a potential bug here. The variable $REPROSTIM_CAPTURE_CLEAN is inside single quotes, so it will not be expanded by the shell. The literal string $REPROSTIM_CAPTURE_CLEAN will be passed to bash -c inside the container, which is likely not what you intend. The same issue exists on the line above for $REPROSTIM_CAPTURE_BUILD.

As you noted in the PR description, it's good practice to merge multiple --run commands to reduce image layers. You can fix the variable expansion and merge the commands at the same time.

Suggested change
--run "bash -c '$REPROSTIM_CAPTURE_CLEAN'" \
--run "chmod a+rX -R /opt"
--run "${REPROSTIM_CAPTURE_CLEAN} && chmod a+rX -R /opt"

@yarikoptic yarikoptic marked this pull request as draft October 10, 2025 14:01
@codecov
Copy link

codecov bot commented Oct 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 3.25%. Comparing base (58c366f) to head (a0c4c87).
⚠️ Report is 41 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##           master    #193      +/-   ##
=========================================
- Coverage    3.57%   3.25%   -0.33%     
=========================================
  Files          22      22              
  Lines        2407    2645     +238     
  Branches      338     371      +33     
=========================================
  Hits           86      86              
- Misses       2321    2559     +238     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vmdocua vmdocua changed the title Ensure that we have correct permissions under /opt Harmonize/refactor reprostim container build and PsychoPy Oct 21, 2025
@vmdocua vmdocua changed the title Harmonize/refactor reprostim container build and PsychoPy Harmonize/refactor reprostim container build and PsychoPy Oct 21, 2025
@vmdocua vmdocua self-assigned this Oct 21, 2025
@vmdocua vmdocua added enhancement New feature or request patch Increment the patch version when merged tests Add or improve existing tests labels Oct 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request patch Increment the patch version when merged tests Add or improve existing tests

Projects

None yet

2 participants