-
Notifications
You must be signed in to change notification settings - Fork 4
Harmonize/refactor reprostim container build and PsychoPy
#193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
TODO: needs to be merged with all the prior --run s into a single one
Summary of ChangesHello @yarikoptic, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a crucial step in the container build process to explicitly manage file permissions within the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds a chmod command to set permissions for the /opt directory within the generated container. My review focuses on improving the implementation. I've identified a bug where shell variables were not being expanded correctly due to improper quoting. My suggestion fixes this bug and also merges the new chmod command with the preceding one, which aligns with your TODO in the description to consolidate --run commands. This will make the Dockerfile generation more efficient by reducing layers.
| --run "bash -c '$REPROSTIM_CAPTURE_CLEAN'" \ | ||
| --run "chmod a+rX -R /opt" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a potential bug here. The variable $REPROSTIM_CAPTURE_CLEAN is inside single quotes, so it will not be expanded by the shell. The literal string $REPROSTIM_CAPTURE_CLEAN will be passed to bash -c inside the container, which is likely not what you intend. The same issue exists on the line above for $REPROSTIM_CAPTURE_BUILD.
As you noted in the PR description, it's good practice to merge multiple --run commands to reduce image layers. You can fix the variable expansion and merge the commands at the same time.
| --run "bash -c '$REPROSTIM_CAPTURE_CLEAN'" \ | |
| --run "chmod a+rX -R /opt" | |
| --run "${REPROSTIM_CAPTURE_CLEAN} && chmod a+rX -R /opt" |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #193 +/- ##
=========================================
- Coverage 3.57% 3.25% -0.33%
=========================================
Files 22 22
Lines 2407 2645 +238
Branches 338 371 +33
=========================================
Hits 86 86
- Misses 2321 2559 +238 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
reprostim container build and PsychoPy
Tasks:
/opt.--runcommands into the single layer.uvcache, use latestpsychopy_linux_installerand try new feature they provided (replace --uninstall-build-packages with --cleanup to include uv cache wieluk/psychopy_linux_installer#91).psychopy_linux_installerunder/opt/psychopy-installerreprostimfolders/files when installed from worktree in CI modereprostimpackage explicitly installed in the container and can be executed:Closes #188
Closes #189