Skip to content

Harmonize/refactor reprostim container build and PsychoPy #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 17 commits into
base: master
Choose a base branch
from
Draft

Harmonize/refactor reprostim container build and PsychoPy #193

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
5004069
Ensure that we have correct permissions under /opt
yarikoptic Oct 10, 2025
12b1bf4
Separate out installation into a separate script
yarikoptic Oct 10, 2025
fe65e55
Temporary rollback generate_container.sh to former version to fix Git…
vmdocua Oct 20, 2025
74688d6
Fix /opt exec permissions back, #188, #193.
vmdocua Oct 20, 2025
29b125a
Fix shellcheck errors, #188, #193.
vmdocua Oct 20, 2025
93ca899
Fix shellcheck errors, #188, #193.
vmdocua Oct 20, 2025
2a8be49
Fix shellcheck errors, #188, #193.
vmdocua Oct 20, 2025
3de1d95
Run psychopy installer with --cleanup option, #188, #193.
vmdocua Oct 20, 2025
36b4713
Provide generic AI project context which can be useful when working o…
vmdocua Oct 20, 2025
f8905bb
Provide generic AI project context which can be useful when working o…
vmdocua Oct 20, 2025
d66a7e0
Add `mc` package to container image, #188, #193.
vmdocua Oct 20, 2025
d6fe24e
Add `mc` package to container image, #188, #193.
vmdocua Oct 20, 2025
6c95558
Update permissions under `/root/,psychopy3` necessary to run PsychoPy…
vmdocua Oct 20, 2025
c917005
Copy `setup_container.sh` bootstrap script to container under /opt lo…
vmdocua Oct 21, 2025
a0c4c87
Merge all commands --run into the single layer and execute it as stan…
vmdocua Oct 21, 2025
03bedf2
Remove `psychopy_linux_installer` and unused `reprostim` files, #188,…
vmdocua Oct 21, 2025
ecffe86
Fix .X11 socket/Xauthority issues to start psychopy UI from docker co…
vmdocua Oct 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion containers/repronim-reprostim/generate_container.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,8 @@ generate() {
--run "bash -c 'b=\$(ls ${PSYCHOPY_VENV_BIN}/python3); echo -e \"#!/bin/sh\n\$b \\\"\\\$@\\\"\" >| /usr/local/bin/python3; chmod a+x /usr/local/bin/python3'" \
--entrypoint python3 \
--run "bash -c '$REPROSTIM_CAPTURE_BUILD'" \
--run "bash -c '$REPROSTIM_CAPTURE_CLEAN'"
--run "bash -c '$REPROSTIM_CAPTURE_CLEAN'" \
--run "chmod a+rX -R /opt"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

There's a potential bug here. The variable $REPROSTIM_CAPTURE_CLEAN is inside single quotes, so it will not be expanded by the shell. The literal string $REPROSTIM_CAPTURE_CLEAN will be passed to bash -c inside the container, which is likely not what you intend. The same issue exists on the line above for $REPROSTIM_CAPTURE_BUILD.

As you noted in the PR description, it's good practice to merge multiple --run commands to reduce image layers. You can fix the variable expansion and merge the commands at the same time.

Suggested change
--run "bash -c '$REPROSTIM_CAPTURE_CLEAN'" \
--run "chmod a+rX -R /opt"
--run "${REPROSTIM_CAPTURE_CLEAN} && chmod a+rX -R /opt"

# --user=reproin \
}

Expand Down
Loading